Skip to content

[GEN] Enhance matrix operators verification#1290

Merged
whitneywhtsang merged 9 commits intollvm-targetfrom
whitneywhtsang/2dblockread_verify
Jun 8, 2024
Merged

[GEN] Enhance matrix operators verification#1290
whitneywhtsang merged 9 commits intollvm-targetfrom
whitneywhtsang/2dblockread_verify

Conversation

@whitneywhtsang
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang self-assigned this Jun 7, 2024
Comment thread third_party/intel/lib/Dialect/TritonGEN/IR/TritonGENOps.cpp Outdated
Comment thread third_party/intel/lib/Dialect/TritonGEN/IR/TritonGENOps.cpp Outdated
Comment thread third_party/intel/lib/Dialect/TritonGEN/IR/TritonGENOps.cpp Outdated
Comment thread third_party/intel/lib/Dialect/TritonGEN/IR/TritonGENOps.cpp Outdated
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread_verify branch from 8515c0a to 4c14bc0 Compare June 7, 2024 20:27
@whitneywhtsang whitneywhtsang requested a review from etiotto June 7, 2024 20:29
@whitneywhtsang whitneywhtsang marked this pull request as ready for review June 7, 2024 20:29
Comment thread test/TritonGEN/tritongen-invalid.mlir Outdated
Comment thread test/TritonGEN/tritongen-invalid.mlir Outdated
Copy link
Copy Markdown
Contributor

@etiotto etiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some inline comments

@whitneywhtsang whitneywhtsang merged commit e2d00da into llvm-target Jun 8, 2024
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/2dblockread_verify branch June 8, 2024 02:00
wdziurdz pushed a commit that referenced this pull request Apr 7, 2026
This is necessary for #1179

---------

Signed-off-by: Gregory Shimansky <gregory.shimansky@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TritonGEN]: Improve diagnostic for 2D block load/store operations.

2 participants