[GEN] Extend Matrix2DBlockLoadOp OCL usages#1259
Merged
Merged
Conversation
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
9141e35 to
e0f7887
Compare
whitneywhtsang
changed the title
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
2 times, most recently
from
f7062cb to
4d115e7
Compare
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
4d115e7 to
33a0aa0
Compare
etiotto
reviewed
Jun 6, 2024
|
|
||
| // CHECK: llvm.func spir_funccc @_Z40intel_sub_group_2d_block_read_8b_8r32x1cPU3AS1viiiDv2_iPt(!llvm.ptr<1>, i32, i32, i32, vector<2xi32>, !llvm.ptr) attributes {passthrough = ["convergent"]} | ||
|
|
||
| llvm.func @triton_gen.2Dblockload(%ptr : !llvm.ptr<1>, %base_width : i32, %base_height : i32, %base_pitch : i32, %x : i32, %y : i32) { |
Contributor
There was a problem hiding this comment.
These tests are duplicates (only test different variants) and I think is better to limit the number of tests we have to maintain. Add one only please.
Contributor
Author
There was a problem hiding this comment.
Limited the number of CHECKs except the first test.
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread
branch
from
4e7de79 to
4429340
Compare
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
2 times, most recently
from
8ae137b to
b504455
Compare
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread
branch
2 times, most recently
from
f721dde to
a24edde
Compare
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
b504455 to
aebd7b7
Compare
whitneywhtsang
requested review from
a team,
Dewei-Wang-sh,
chengjunlu and
etiotto
Contributor
Author
|
This change depends on coming agama rolling driver. |
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
aebd7b7 to
8df09ed
Compare
jopperm
approved these changes
Jun 7, 2024
etiotto
reviewed
Jun 7, 2024
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
8df09ed to
d47921d
Compare
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/2dblockread+
branch
from
d47921d to
607d0f4
Compare
etiotto
approved these changes
Jun 10, 2024
whitneywhtsang
added a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
added a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.