[GEN] Add cache controls decoration to 2d_block_read builtin calls

[victor-eds]

#1224 converts triton_gen.2Dblockload to OCL builtin 2d_block_read calls. Add cache controls decoration capturing original cache_control semantics.

[victor-eds]

Addresses #1233

[whitneywhtsang]

Can you please check if the expected GenISA with expected cache control is generated at the end from shader dump?

[victor-eds]

Can you please check if the expected GenISA with expected cache control is generated at the end from shader dump?

Issue's this won't work till IGC picks KhronosGroup/SPIRV-LLVM-Translator@c8bfc33.

[whitneywhtsang]

Can you please check if the expected GenISA with expected cache control is generated at the end from shader dump?

Issue's this won't work till IGC picks KhronosGroup/SPIRV-LLVM-Translator@c8bfc33.

IIUC the feature is needed for LLVMIR -> SPV translation, which doesn't need IGC to update the SPV -> LLVMIR portion. #1251 updated the SPIRV-LLVM-Translator Triton uses.

[victor-eds]

IIUC the feature is needed for LLVMIR -> SPV translation, which doesn't need IGC to update the SPV -> LLVMIR portion. #1251 updated the SPIRV-LLVM-Translator Triton uses.

Running latest llvm-spirv gives a sensible output:

5 Decorate 36 CacheControlLoadINTEL 0 0
5 Decorate 37 CacheControlLoadINTEL 1 0
...
4 Bitcast 4 38 37
4 Bitcast 8 39 31
10 FunctionCall 2 40 10 38 21 22 23 34 39

I don't have access to an IGC development version handling this, tho, so I cannot currently test on my side.

[victor-eds]

ola.txt

Here's the full SPIR-V dump. It's .txt as apparently GitHub cares about extensions 🤦

[jopperm]

Just test case nits; code LGTM. You probably have to watch out for #1259 which extends the name mangling for the OCL builtins (transform/transpose).

[victor-eds]

Just test case nits; code LGTM. You probably have to watch out for #1259 which extends the name mangling for the OCL builtins (transform/transpose).

I think this should work regardless of that. We would just accept more cases.

[whitneywhtsang]

This change looks good to me, let's merge this after verifying it works end to end.