Skip to content

[GEN] Change existing OCL lowering to the new interface#1224

Merged
whitneywhtsang merged 2 commits into
llvm-targetfrom
whitneywhtsang/2dblockread
Jun 10, 2024
Merged

[GEN] Change existing OCL lowering to the new interface#1224
whitneywhtsang merged 2 commits into
llvm-targetfrom
whitneywhtsang/2dblockread

Conversation

@whitneywhtsang
Copy link
Copy Markdown
Contributor

@whitneywhtsang whitneywhtsang commented Jun 1, 2024 •
edited
Loading

Please do not squash and merge this PR.

@whitneywhtsang whitneywhtsang self-assigned this Jun 1, 2024
@whitneywhtsang whitneywhtsang linked an issue Jun 1, 2024 that may be closed by this pull request
[GEN] Use OCL builtin for 2D block read available on driver 881.12 #1199
Closed
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread branch from db8db94 to c24267e Compare June 1, 2024 19:23
@whitneywhtsang
Copy link
Copy Markdown
Contributor Author

whitneywhtsang commented Jun 1, 2024

Awaiting for a release driver that contains the support of the OCL builtin, but ready for review.

@whitneywhtsang whitneywhtsang marked this pull request as ready for review June 2, 2024 21:29
victor-eds
victor-eds reviewed Jun 3, 2024
View reviewed changes
Copy link
Copy Markdown

@victor-eds victor-eds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are CI failures related to these changes?

FMarno
FMarno reviewed Jun 3, 2024
View reviewed changes
Comment thread third_party/intel/lib/TritonGENToLLVM/TritonGENToLLVMPass.cpp
Comment thread test/TritonGEN/tritongen-to-llvm.mlir Outdated
etiotto
etiotto reviewed Jun 3, 2024
View reviewed changes
Comment thread third_party/intel/lib/TritonGENToLLVM/TritonGENToLLVMPass.cpp
@whitneywhtsang
Copy link
Copy Markdown
Contributor Author

whitneywhtsang commented Jun 3, 2024

Are CI failures related to these changes?

Yes, will pass when we update to the next agama rolling driver.

@whitneywhtsang whitneywhtsang requested a review from victor-eds June 3, 2024 18:46
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread branch from c24267e to 12d6da7 Compare June 4, 2024 00:28
@whitneywhtsang whitneywhtsang mentioned this pull request Jun 4, 2024
Closed
@victor-eds victor-eds mentioned this pull request Jun 4, 2024
Merged
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread branch 5 times, most recently from f721dde to a24edde Compare June 7, 2024 04:42
@whitneywhtsang whitneywhtsang requested a review from FMarno June 7, 2024 05:07
FMarno
FMarno approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@FMarno FMarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine to me

Comment thread test/TritonGEN/tritongen-to-llvm.mlir Outdated
etiotto
etiotto reviewed Jun 7, 2024
View reviewed changes
Comment thread test/TritonGEN/tritongen-to-llvm.mlir Outdated
@whitneywhtsang whitneywhtsang mentioned this pull request Jun 8, 2024
Merged
@whitneywhtsang whitneywhtsang requested a review from etiotto June 9, 2024 21:42
whitneywhtsang added a commit that referenced this pull request Jun 10, 2024
@whitneywhtsang
[GEN] Change existing OCL lowering to the new interface (#1224)
9eb1e2d 
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread branch from 761892b to c99dc29 Compare June 10, 2024 17:16
@whitneywhtsang whitneywhtsang marked this pull request as draft June 10, 2024 17:31
@whitneywhtsang
[GEN] Change existing OCL lowering to the new interface (#1224)
7464773 
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang
[GEN] Extend Matrix2DBlockLoadOp OCL usages (#1259)
75411ea 
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang force-pushed the whitneywhtsang/2dblockread branch from c99dc29 to 75411ea Compare June 10, 2024 22:08
@whitneywhtsang whitneywhtsang marked this pull request as ready for review June 10, 2024 22:39
@whitneywhtsang whitneywhtsang merged commit c141986 into llvm-target Jun 10, 2024
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/2dblockread branch June 10, 2024 22:39
whitneywhtsang pushed a commit that referenced this pull request Jun 17, 2024
[GEN] Add cache controls decoration to 2d_block_read builtin calls (#…
31f64d2 
…1247)

#1224 converts `triton_gen.2Dblockload` to OCL builtin `2d_block_read`
calls. Add cache controls decoration capturing original `cache_control`
semantics.

---------

Signed-off-by: Victor Perez <victor.perez@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etiotto etiotto etiotto approved these changes

@chengjunlu chengjunlu chengjunlu approved these changes

@Dewei-Wang-sh Dewei-Wang-sh Awaiting requested review from Dewei-Wang-sh

@victor-eds victor-eds Awaiting requested review from victor-eds

+1 more reviewer

@FMarno FMarno FMarno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@whitneywhtsang whitneywhtsang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[GEN] Use OCL builtin for 2D block read available on driver 881.12

5 participants

@whitneywhtsang @FMarno @victor-eds @etiotto @chengjunlu