feat: added support for couchbase v4.4.4

[abhilash-sivan]

refs INSTA-20554

couchnode changelog: couchbase/couchnode@v4.4.3...v4.4.4

In this update, there is code changes that affects our instrumentation.

We have instrumented cluster.analyticsQuery for analyticsServices,

await this._cluster.analyticsQuery :
https://github.com/couchbase/couchnode/blob/e855b094cd1b0140ffefc40f32a828b9134d181c/lib/analyticsindexmanager.ts#L1039

now the core implementation changed and we have to instrument all functions separately like
conn.managementAnalyticsDataverseDrop :
https://github.com/couchbase/couchnode/blob/9e3e1f1174d5e3aa29f6499c08fafd2ccbf8dbdf/lib/analyticsindexmanager.ts#L1202C21-L1202C58

[kirrg001]

Added some first comments.

[kirrg001]

qs: What will we loose if we only use the new instrumentation code?

We would loose two select statements for..?

This select statement looks a bit poor:

sql: 'SELECT'

In general: Please add comments before requesting review for changes like that to give attention to a critical change. I almost have overseen the change. Thanks!

[abhilash-sivan]

qs: What will we loose if we only use the new instrumentation code?

If we use only the latest instrumentation code, we will lose the ability to get SQL statements.
In the new implementation, we won't get the queries explicitly.

This select statement looks a bit poor

In the old instrumentation, some queries are available in the spans. And trimming it for verifying in the test.

In the new instrumentation, we use the function name to verify the spans

[kirrg001]

What are the SQL statements? The test only displays sql: 'SELECT'.

[abhilash-sivan]

eg:

{
  couchbase: {
    hostname: 'couchbase://127.0.0.1:11210',
    sql: 'CREATE INDEX `i_f72ea422-b62c-11ef-9ebd-f3edefeaf7fc` ON `d_f72ea420-b62c-11ef-9ebd-f3edefeaf7fc`.`d_f72ea421-b62c-11ef-9ebd-f3edefeaf7fc` (`name`: string)'
  }
}
{
  couchbase: {
    hostname: 'couchbase://127.0.0.1:11210',
    bucket: 'projects',
    type: 'membase',
    sql: 'SELECT d.* FROM `Metadata`.`Dataset` d WHERE d.DataverseName <> "Metadata"'
  }
}

this is the actual span data being created using the old instrumentation logic.

Also in test,
span => expect(span.data.couchbase.sql).to.contain(options.sql || 'GET'),

we are checking the strings presence in the SQL statement.

[kirrg001]

Okay. Please add a TODO for v5 to drop the instrumentation code for v443. Please add a TODO in the codebase for v5.

[abhilash-sivan]

We need to support both versions of v4 upon the release of v5, right?

[kirrg001]

Yes exactly 👍 We can drop the logic for 4.4.3 in v5

[kirrg001]

Okay. Please add a TODO for v5 to drop the instrumentation code for v443. Please add a TODO in the codebase for v5.

[kirrg001]

LGTM

[aryamohanan]

added minor comment, LGTM