chore: cleanup

instana · Dec 6, 2024 · 3723ce6 · 3723ce6
1 parent f684b31
commit 3723ce6
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 41 deletions.
diff --git a/packages/collector/test/tracing/database/couchbase/test.js b/packages/collector/test/tracing/database/couchbase/test.js
@@ -455,14 +455,6 @@ mochaSuiteFn('tracing/couchbase', function () {
               verifySpans(agentControls, controls, {
                 spanLength: 9,
                 verifyCustom: (entrySpan, spans) => {
-                  // expectExactlyOneMatching(
-                  //   spans,
-                  //   verifyCouchbaseSpan(controls, entrySpan, {
-                  //     bucket: 'projects',
-                  //     type: 'membase',
-                  //     sql: 'NOW SELECT '
-                  //   })
-                  // );
                   expectExactlyNMatching(
                     spans,
                     1,
@@ -490,15 +482,6 @@ mochaSuiteFn('tracing/couchbase', function () {
                       sql: 'CREATE INDEX '
                     })
                   );
-                  // expectExactlyNMatching(
-                  //   spans,
-                  //   1,
-                  //   verifyCouchbaseSpan(controls, entrySpan, {
-                  //     bucket: '',
-                  //     type: '',
-                  //     sql: 'SELECT'
-                  //   })
-                  // );
                   expectExactlyNMatching(
                     spans,
                     1,

diff --git a/packages/core/src/tracing/instrumentation/database/couchbase.js b/packages/core/src/tracing/instrumentation/database/couchbase.js
@@ -94,7 +94,7 @@ function instrumentCluster(cluster, connectionStr) {
   // #### FTS SERVICE (.searchIndexes().)
   instrumentSearchIndexes(cluster, connectionStr);
 
-  // #### ANALYTICS SERVICES (.analyticsIndexes().) version >= 4.4.4
+  // #### ANALYTICS SERVICES (.analyticsIndexes().)
   instrumentAnalyticsIndexes(cluster, connectionStr);
 
   // #### N1QL SERVICE (.queryIndexes().)
@@ -119,29 +119,6 @@ function instrumentCluster(cluster, connectionStr) {
       ).apply(originalThis, originalArgs);
     };
   });
-
-  // #### ANALYTICS SERVICE (.analyticsIndexes().) v <= 4.4.3
-  shimmer.wrap(cluster, 'analyticsQuery', function instanaClusterAnalyticsQuery(original) {
-    return function instanaClusterAnalyticsQueryWrapped() {
-      const originalThis = this;
-      const originalArgs = arguments;
-      const sqlStatement = originalArgs[0] || '';
-
-      return instrumentOperation(
-        {
-          connectionStr,
-          sql: tracingUtil.shortenDatabaseStatement(sqlStatement),
-          resultHandler: (span, result) => {
-            if (result && result.rows && result.rows.length > 0 && result.rows[0].BucketName) {
-              span.data.couchbase.bucket = result.rows[0].BucketName;
-              span.data.couchbase.type = bucketLookup[span.data.couchbase.bucket];
-            }
-          }
-        },
-        original
-      ).apply(originalThis, originalArgs);
-    };
-  });
 }
 
 function instrumentCollection(cluster, connectionStr) {