Skip to content

Commit

Permalink
chore: cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
abhilash-sivan committed Dec 11, 2024
1 parent 091501d commit 366cebc
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion packages/collector/test/tracing/database/couchbase/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@ app.post('/queryindexes-callback', (req, res) => {
scope2.query(qs1, err3 => {
if (err3) return res.status(500).json({ err: err3.message });

// Added a temporarily promise catch handler due to an issue in the package.
// Added a temporary promise catch handler due to an issue in the package.
// see https://github.com/couchbase/couchnode/issues/123
scope2
.query(qs2)
Expand Down
2 changes: 1 addition & 1 deletion packages/collector/test/tracing/database/couchbase/app.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ app.post('/queryindexes-callback', (req, res) => {
cluster.queryIndexes().createIndex(bucket2.name, idx2, ['name'], () => {
cluster.query(qs, () => {
scope2.query(qs1, () => {
// Added a temporarily promise catch handler due to an issue in the package.
// Added a temporary promise catch handler due to an issue in the package.
// see https://github.com/couchbase/couchnode/issues/123
scope2
.query(qs2)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function instrumentCluster(cluster, connectionStr) {

// v4.4.4 introduced a breaking code change.
// We are no longer able to extract the SQL statements for "analyticsindexes".
// see chnages: https://github.com/couchbase/couchnode/compare/v4.4.3...v4.4.4?diff=split&w=
// see changes: https://github.com/couchbase/couchnode/commit/b8118b8dd05c710e0f0d898ba8e16372028ea294
if (instrumentLatest) {
// #### ANALYTICS SERVICES (.analyticsIndexes().) v >= 4.4.4
instrumentAnalyticsIndexes(cluster, connectionStr);
Expand Down

0 comments on commit 366cebc

Please sign in to comment.