feat: consistent labeling of all resources

[rswanson]

No description provided.

[rswanson]

• feat: manual triggered release workflow #13
• fix: consistently being validated #10
• fix: dry constants #9
• feat: quincey #8
• feat: consistent labeling of all resources #5 👈 (View in Graphite)
• feat: aws package, so builder and signet_node are isolated to k8s resources #4
• feat: utils package for better DRY #3
• feat: signet-node #2
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR implements consistent labeling across Kubernetes resources by centralizing label creation in a single helper and refactoring resource definitions to use it.

• Moved and updated CreateResourceLabels to pkg/utils/labels.go and its tests.
• Refactored resource creation (PVCs, ConfigMaps, Deployments, Services, StatefulSets) to use consistent labeling and helper functions.
• Updated naming conventions across the signet_node and builder components for clarity and consistency.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/utils/labels_test.go	Added tests to verify consistent label creation.
pkg/utils/labels.go	Introduced centralized label creation with merging additional labels.
pkg/signet_node/signet_node.go	Refactored resource creations to leverage helper functions for labels.
pkg/signet_node/helpers_test.go	Updated tests to reflect new label location.
pkg/signet_node/helpers.go	Removed obsolete CreateResourceLabels function.
pkg/builder/helpers.go	Updated to call centralized label helper.
pkg/builder/builder.go	Refactored resource names and labels for service accounts, deployments, and services.

Comments suppressed due to low confidence (2)

pkg/signet_node/signet_node.go:69

• The config map name 'exex-configmap' appears to be misspelled. Consider renaming it to 'exec-configmap' or 'execution-configmap' for clarity and consistency.

executionConfigMapName := "exex-configmap"

pkg/signet_node/signet_node.go:139

• [nitpick] Appending '-set' to hostStatefulSetName (which is already 'signet-node-execution-set') leads to a redundant resource name ('signet-node-execution-set-set'). Verify if this naming is intentional or adjust to avoid duplication.

hostStatefulSetResourceName := fmt.Sprintf("%s-set", hostStatefulSetName)

[rswanson]

Merge activity

• May 29, 3:28 PM UTC: @rswanson merged this pull request with Graphite.