fix: consistently being validated

[rswanson]

No description provided.

[rswanson]

• feat: manual triggered release workflow #13
• fix: consistently being validated #10 👈 (View in Graphite)
• fix: dry constants #9
• feat: quincey #8
• feat: consistent labeling of all resources #5
• feat: aws package, so builder and signet_node are isolated to k8s resources #4
• feat: utils package for better DRY #3
• feat: signet-node #2
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR updates validation logic and associated tests for multiple component arguments to ensure consistent error messages and required field checks across SignetNode, Builder, and Quincey components.

• Updated SignetNodeComponentArgs and SignetNodeEnv validations and tests with additional required fields and error messages.
• Revised BuilderEnv validations and adjusted test expectations to accommodate newly added required fields.
• Added tests for QuinceyComponentArgs validations to verify proper error reporting.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/signet_node/validation_test.go	Updated tests to check new required field validations and messages.
pkg/signet_node/validation.go	Modified required field checks and error messages for SignetNode.
pkg/quincey/validation_test.go	Added comprehensive validations for Quincey component arguments.
pkg/builder/validation_test.go	Adjusted test expectations for BuilderEnv validations.
pkg/builder/validation.go	Expanded required field validations for BuilderEnv with new fields.
pkg/builder/types.go	Added validation tags for required fields in BuilderEnv.

Comments suppressed due to low confidence (1)

pkg/builder/validation_test.go:66

• The expected error message was changed from 'builder port is required' to 'auth token refresh interval is required'. Please double-check that this aligns with the intended validation logic for BuilderEnv.

assert.Equal(t, "auth token refresh interval is required", err.Error())

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

This PR adds comprehensive validation checks for newly introduced fields in the SignetNode, Builder, and Quincey components, and updates related tests and struct tags to enforce required inputs.

• Expanded Validate() methods to cover all new Pulumi inputs in SignetNodeComponentArgs, SignetNodeEnv, and BuilderEnv.
• Updated unit tests to reflect new validation rules and removed older env-specific test suites.
• Added validate:"required" tags to struct definitions in types.go for automatic schema validation.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/signet_node/validation.go	Added nil-checks for new SignetNodeComponentArgs and SignetNodeEnv fields
pkg/signet_node/types.go	Annotated SignetNodeEnv fields with validate:"required"
pkg/signet_node/validation_test.go	Adjusted tests to cover validation of added SignetNode fields, removed old env tests
pkg/quincey/validation_test.go	Created tests for QuinceyComponentArgs validation scenarios
pkg/builder/validation.go	Extended BuilderEnv.Validate() to require all newly added fields
pkg/builder/types.go	Added validate:"required" tags on BuilderEnv fields
pkg/builder/validation_test.go	Updated builder component args tests to align with reordered validation

Comments suppressed due to low confidence (4)

pkg/signet_node/validation_test.go:68

• The test invalidArgs1 provides Namespace but omits Name, so Validate() returns "name is required" rather than "namespace is required". Update the assertion to expect "name is required".

assert.Contains(t, err.Error(), "namespace is required")

pkg/signet_node/validation_test.go:104

• [nitpick] The detailed per-field tests for SignetNodeEnv.Validate() were removed. Consider adding targeted tests for each required env field to ensure all error paths are covered.

// Test with invalid env

pkg/signet_node/validation.go:46

• [nitpick] Error messages use lowercase "url" here but uppercase acronyms elsewhere (e.g., "RPC URL"). Standardize the casing of acronyms in all error messages for consistency.

if env.BlobExplorerUrl == nil {

pkg/quincey/validation_test.go:70

• [nitpick] The test only checks a high-level error for an invalid QuinceyEnv. Add tests for individual missing QuinceyEnv fields to verify each validation message.

assert.Contains(t, err.Error(), "env is invalid")

[rswanson]

Merge activity

• Jun 3, 2:44 PM UTC: @rswanson merged this pull request with Graphite.