-
Notifications
You must be signed in to change notification settings - Fork 0
feat: manual triggered release workflow #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd6d961 to
af1fc29
Compare
af1fc29 to
312ca45
Compare
548a2a7 to
ffc61e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A broad refactor that adds a manual GitHub Actions–driven release workflow and centralizes constants, validation, and utility functions across multiple packages.
- Introduce a
release.ymlworkflow withworkflow_dispatchfor manual releases. - Extract shared defaults (ports, labels, resource requirements) into constants and
utilshelpers. - Expand and enforce validation for SignetNode, Quincey, Builder, and AWS IAM components with updated tests and type tags.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/release.yml | Add manual-triggered release workflow |
| pkg/utils/env.go | Add ParsePortWithDefault, CreateResourceRequirements, CreatePersistentVolumeClaim |
| pkg/signet_node/types.go | Add validate:"required" tags, update SignetNodeEnv struct |
| pkg/signet_node/validation.go | Expand SignetNodeComponentArgs and SignetNodeEnv validation |
| pkg/signet_node/validation_test.go | Update tests for new SignetNode validation rules |
| pkg/quincey/constants.go | Extract Quincey defaults and identifiers |
| pkg/quincey/types.go | Remove inline constants, rely on shared constants.go |
| pkg/quincey/quincey.go | Replace literals with constants, use utils.ParsePortWithDefault |
| pkg/quincey/validation_test.go | Adjust Quincey component args tests |
| pkg/builder/constants.go | Define Builder defaults and suffix constants |
| pkg/builder/types.go | Add validate:"required" tags to BuilderEnv fields |
| pkg/builder/validation.go | Expand BuilderEnv.Validate for all required fields |
| pkg/builder/validation_test.go | Update builder tests to match new validation order |
| pkg/builder/builder.go | Replace literals and inline probes with constants and helpers |
| pkg/aws/constants.go | Introduce IAM policy/version constants |
| pkg/aws/iam.go | Refactor IAM resource creation to use constants |
Comments suppressed due to low confidence (4)
pkg/signet_node/types.go:64
- There's a typo in the Pulumi tag for
HostStartTimestamp(hostStartTimepstamp); it should behostStartTimestampto match the field name.
HostStartTimestamp pulumi.StringInput `pulumi:"hostStartTimepstamp" validate:"required"`
pkg/signet_node/types.go:51
- The
RustLogfield lacks avalidate:"required"tag but is checked inSignetNodeEnv.Validate; add the tag for consistency.
RustLog pulumi.StringInput `pulumi:"rustLog"`
pkg/signet_node/validation_test.go:67
- This test (
invalidArgs1) omitsNameand will fail onname is requiredfirst; update the expected message to "name is required".
assert.Contains(t, err.Error(), "namespace is required")
pkg/utils/env.go:151
- There are no unit tests covering
ParsePortWithDefault; adding tests for valid and invalid port strings would improve coverage.
// ParsePortWithDefault converts a port string to an integer with a default fallback
312ca45 to
bf5093d
Compare
ffc61e3 to
0f65a84
Compare
0f65a84 to
07f6914
Compare

No description provided.