role-binding v2 schema and IAPL #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bailinhe
force-pushed
the
role-binding-schema
branch
from
8efc9e7
to
c5fd68b
Compare
Closed
jnschaeffer
requested changes
Mar 15, 2024
jnschaeffer
reviewed
Mar 15, 2024
bailinhe
force-pushed
the
role-binding-schema
branch
2 times, most recently
from
27840bd
to
41bcf2e
Compare
bailinhe
force-pushed
the
role-binding-schema
branch
from
41bcf2e
to
0080dfb
Compare
bailinhe
force-pushed
the
role-binding-schema
branch
from
8d903da
to
0de1390
Compare
jnschaeffer
reviewed
Apr 1, 2024
Comment on lines
+470
to
+555
| // Relationships like member_roles, available_roles, are created to support | ||
| // role inheritance, e.g., an org should be able to use roles defined by its |
There was a problem hiding this comment.
This needs more explanation, I think, preferably in the Markdown doc.
internal/iapl/rbac.go
Outdated
Comment on lines
13
to
15
| // AvailableRoleRelation is the name of the relationship that list all roles | ||
| // that are available for a given resource | ||
| AvailableRoleRelation = "avail_role" |
There was a problem hiding this comment.
This seems like it could be named a little better, since it's actually used as an action everywhere, not as a relation. Maybe this would be better? Not sure.
Suggested change
| // AvailableRoleRelation is the name of the relationship that list all roles | |
| // that are available for a given resource | |
| AvailableRoleRelation = "avail_role" | |
| // UseRoleAction is the name of the action that allows the use of a role | |
| // for listing, binding, etc in the context of a given resource | |
| UseRoleAction = "iam_use_role" |
bailinhe
force-pushed
the
role-binding-schema
branch
3 times, most recently
from
0dc1a3a
to
8d474ee
Compare
jnschaeffer
reviewed
Apr 4, 2024
| */ | ||
| type RBAC struct { | ||
| // RoleResource is the name of the resource type that represents a role. | ||
| RoleResource RBACResourceDefinition |
There was a problem hiding this comment.
Is RBACResourceDefinition here so we can create the resource type?
There was a problem hiding this comment.
Yes. I changed that to be not private because I realized at some point we need to create a policy for tests
jnschaeffer
previously approved these changes
Apr 4, 2024
bailinhe
force-pushed
the
role-binding-schema
branch
2 times, most recently
from
d96eb76
to
2563696
Compare
Co-authored-by: John Schaeffer <[email protected]> Signed-off-by: Bailin He <[email protected]>
bailinhe
force-pushed
the
role-binding-schema
branch
from
2563696
to
4d0a201
Compare
jnschaeffer
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to separate roles from bindings in permissions-api, we need to update the generated SpiceDB schema with a definition for bindings and permissions that check both direct assignment to roles and bindings (i.e., we don’t want to break existing assignments). The scope of this task is to update permissions-api to generate a SpiceDB schema with a binding definition that associates a subject (i.e., any principal) to a role.
see this doc for more