RBAC V2 - Roles APIs #245
Merged
RBAC V2 - Roles APIs #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bailin He <[email protected]>
jnschaeffer
requested changes
Apr 16, 2024
Signed-off-by: Bailin He <[email protected]>
jnschaeffer
reviewed
Apr 19, 2024
| @@ -26,6 +26,22 @@ const ( | |||
| GrantRelationship = "grant" | |||
| ) | |||
|
|
|||
| // RoleAction is the list of actions that can be performed on a role resource | |||
| type RoleAction string | |||
There was a problem hiding this comment.
Why do we have an entire type for this?
There was a problem hiding this comment.
I think the actions should be an enum, same goes with RoleBindingActions
internal/query/roles_v2.go
Outdated
|
|
||
| defer span.End() | ||
|
|
||
| roleName = strings.TrimSpace(roleName) |
There was a problem hiding this comment.
Right; I think that would be good.
Comment on lines
+577
to
+582
| // there could be multiple subject types for a permission, | ||
| // e.g. | ||
| // infratographer/rolev2:lb_viewer#loadbalancer_get_rel@infratographer/user:* | ||
| // infratographer/rolev2:lb_viewer#loadbalancer_get_rel@infratographer/client:* | ||
| // here we only need one of them since the action is the only thing we care | ||
| // about |
There was a problem hiding this comment.
This will probably bite us. A better solution would probably be to have some singleton subject set definition that points to all subject types.
There was a problem hiding this comment.
I agree a more elegant solution is more desirable, but I think we can have a seperate PR to play with the IAPL
bailinhe
force-pushed
the
rbac-v2-roles
branch
2 times, most recently
from
6f0d6c2
to
03ddab7
Compare
Co-authored-by: John Schaeffer <[email protected]> Signed-off-by: Bailin He <[email protected]>
jnschaeffer
approved these changes
Apr 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue work on #219
The API should be updated to use them in place of direct role assignments. The scope of this task is to make the following API changes: