Apply suggestions from code review

Co-authored-by: John Schaeffer <[email protected]> Signed-off-by: Bailin He <[email protected]>
infratographer · Mar 22, 2024 · 8d903da · 8d903da
1 parent 0080dfb
commit 8d903da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/iapl/policy.go b/internal/iapl/policy.go
@@ -455,7 +455,7 @@ func (v *policy) createRoleBindingResourceType() {
 	}
 
 	// 3. create a list of action-bindings representing permissions for all the
-	// actions
+	// actions in the policy
 	actionbindings := make([]ActionBinding, 0, len(v.ac))
 
 	for actionName := range v.ac {

diff --git a/internal/iapl/rbac.go b/internal/iapl/rbac.go
@@ -87,7 +87,7 @@ For example, consider the following spicedb schema:
 		relation rolebinding_delete_rel: user:* | client:*
 	}
 
-	definition role_binding {
+	definition rolebinding {
 		relation role: role
 		relation subject: user | group#member
 		permission view_organization = subject & role->view_organization
@@ -99,7 +99,7 @@ For example, consider the following spicedb schema:
 ```
 in IAPL policy terms:
 - the RoleResource would be "role"
-- the RoleBindingResource would be "role_binding",
+- the RoleBindingResource would be "rolebinding",
 - the RoleRelationshipSubject would be `[user, client]`.
 - the RoleBindingSubjects would be `[{name: user}, {name: group, subjectrelation: member}]`.
 */