feat(mobile): open in browser

[YarosMallorca]

Description

Implements #21020

How Has This Been Tested?

Tested on Android AVD. Needs testing on iOS.

Screenshots

Please describe to which degree, if any, an LLM was used in creating this pull request.

AI was not used during development

[timonrieger]

tested on iOS ✅

Minor suggestion

Maybe group the action in a different/existing section in the menu 🤔 , otherwise there are a lot grey dividers

[YarosMallorca]

@timonrieger thanks for testing, it is strange that there are so many dividers, I gotta test it on a stack, because for me on a regular asset it looks like this:

[timonrieger]

@timonrieger thanks for testing, it is strange that there are so many dividers, I gotta test it on a stack, because for me on a regular asset it looks like this:

it is not on all assets, maybe check the asset i sent above. There is code block to set the prioritization

[1661410107114145152525]

Just because it is not released yet: Is there any chance to position it a bit better for quicker access? I would need to tap that for about 20% of my media (as quite a lot is 360°) and the upper right menu is quite hard to tap when scrolling through images (as those who use it, might use it quite often and more as a primary than secondary function). Or is there some kind of configuration where I can define stuff like that? Please don't get wrong, I am already really, really happy about the effort you took for this. If it's not possible/feasible, no issue either, I don't want to make any circumstances.

Thanks a lot again for your help! @YarosMallorca (and also @timonrieger for testing and the rest of the team / community) ❤️

[1661410107114145152525]

I could also test it on Android if that helps (if anyone provides an apk). Does it also work on videos? Will we be able to swipe to the next or previous image after opening the image in the web (so does it open in the timeline or respective album)? @YarosMallorca

[timonrieger]

Is there any chance to position it a bit better for quicker access?

Very likely that it's gonna stay like that. It's a niche feature or at least less important for users than the other actions in the bottom viewer.

[timonrieger]

Does it also work on videos?

Yes

Will we be able to swipe to the next or previous image after opening the image in the web (so does it open in the timeline or respective album)?

It opens the same view in the browser

Video

in.MP4

[YarosMallorca]

It opens the same view in the browser

Technically correct, but it doesn't deep-link into an album/view yet, that's something that could be improved in the future.

[timonrieger]

@YarosMallorca this section here

https://github.com/immich-app/immich/blob/68eada7d7cc0140d2c07f3934885af4c8630da2c/mobile/lib/utils/action_button.utils.dart#L260:L279

[1661410107114145152525]

Thanks a lot for your help and answers you two! @YarosMallorca and @timonrieger :)

[1661410107114145152525]

Technically correct, but it doesn't deep-link into an album/view yet, that's something that could be improved in the future.

Got it, thanks! :) Should I create a feature request for that or do you have follow-up issues for things like that? @YarosMallorca

[YarosMallorca]

@1661410107114145152525 No need to open another feature request, I have this in mind and will see if it's feasible.

[1661410107114145152525]

Is there any chance to position it a bit better for quicker access?

Very likely that it's gonna stay like that. It's a niche feature or at least less important for users than the other actions in the bottom viewer.

Hm, I understand. A general question and different topic but explains why I asked for a different positioning too: Why does your three-dot-menu behave differently than many others in Android like e.g. the one of Chromium Browsers (like Google Chrome, Brave, ...) or messaging apps (WhatsApp, Signal,...)? Mostly it is possible to hold, the menu already opens while doing so, drag and the selected entry where you lift your finger gets opened. This makes using a lot more handy, especially since those menus are often quite hard to reach with one hand, speeds things up, espedially when getting used to things and working with muscle memory. @YarosMallorca

[1661410107114145152525]

@1661410107114145152525 No need to open another feature request, I have this in mind and will see if it's feasible.

Great to hear that, thanks a lot! ❤️

[YarosMallorca]

Why does your three-dot-menu behave differently than many others in Android?

This is going off-topic, but it's how MenuAnchor behaves in Flutter by default (I guess so it's consistent between Android and iOS), and we haven't modified the behavior. If this would be done, it would be in a separate PR, however it's quite a minor thing in my opinion.

[1661410107114145152525]

Why does your three-dot-menu behave differently than many others in Android?

@YarosMallorca This is going off-topic, but it's how MenuAnchor behaves in Flutter by default [...]. If this would be done, it would be in a separate PR, however it's quite a minor thing in my opinion.

Yeah I know, I just did not knew where to ask you better, sorry.Thank you for the explanation! :)

@YarosMallorca (I guess so it's consistent between Android and iOS), and we haven't modified the behavior.

This can't be the reason as on iOS/iPadOS it is the same as on Android. E.g. Apples own Photos app does behave like that for three-dot-menus too, and many similar apps too. So the default creates an inconsistent, different behavior than what users are used too rather than consistency. I will create a feature request for that, thanks! :)

[1661410107114145152525]

@YarosMallorca feat: deeplink into favorites, trash & archived

No way 😂 - you are the goat! Thanks! ❤️

[1661410107114145152525]

@YarosMallorca feat: deeplink into favorites, trash & archived

If I may ask: Is showing it in the timeline the default/already works out of the box if opened from the timeline or will it come as a follow-up or so?

[YarosMallorca]

It is already the default and works (from the main timeline), routes that aren't supported yet (such as from a person or album view) will open the photo in the main timeline.

[1661410107114145152525]

@YarosMallorca: It is already the default and works (from the main timeline), routes that aren't supported yet (such as from a person or album view) will open the photo in the main timeline.

Perfect! :o Thank you for the explanation and great implementation! <3

[alextran1502]

After heavy consideration, I reject this PR as I don't see this is a feature that many users will user, and the kebab menu should be reserved for more common action as space is limited

[1661410107114145152525]

After heavy consideration, I reject this PR as I don't see this is a feature that many users will user, and the kebab menu should be reserved for more common action as space is limited

Hi @alextran1502 this is really sad to hear. If there was feature parity between web and app I would fully understand it, but there isn't. Especially for users with 360° footage that feature is the only way to be able to use the mobile app properly at all. If you don't consider these users important, why does Immich support this format at all. For me it was the key selling point to switch from Nextcloud Photos though I just had it properly set up.

But not only for 360° content, if users see an image and want to see it next to the other images on the map (many use cases I could explain here, if necessary), there is currently no way to do that. Same goes for many other features where development in the app is either ongoing (e.g. OCR), on hold or will propably never be done for the app. So it wouldn't just solve current issues, but also future ones.

Though saying "just wait" is something one could do for at least some of those issues (like OCR), but it is a difference, to wait for a feature that isn't there at all versus one, that is already in the web and celebrated in release notes and so on.

Besides that is isn't incommon at all, e.g. in the Nextcloud Memories app, there is also a button that does something similar (switches from the mobile version to the web version in a where more features are available. Same goes for a lot of types of sites, where the web version has limited festures or isn't just as good optimized for touch and therefore an "Open in app" button is common to show.

That you struggled to decide here has a reason and I hope you see these arguments give the pro side in you enough reason to not throw away this well implemented, livesaving feature.

---

It doesn't have to be in the three-dot-menu

If you are convinced by the festure but it is just about the placement in the three-dot-menu, this is something we should rather solve together, as UI issues are solvable.

Another great place could be in the image info modal, that one could open by swiping up too. There the URL of the image/video could either be an own entry (same es the filename but with an link or open in new icon) and on tap it opens in the browser, or it is the subtitle to the filename (same look and type of information as the exact coordinates below the places name). That way the three-dot menu is not used and lives instead in the modal, where already is much space to scroll etc.

[1661410107114145152525]

Hi @alextran1502 , just a quick follow-up in case my last comment got buried after the PR was closed. When you get a chance, I’d really appreciate a brief reply. Thank you so much! ❤️

Sorry if this is ignoring any Github rules, there is no intention to spam or annoy, I just wanted to help out with my experience as a professional UX/UI Designer. I could also do some mockups if that helps.

@YarosMallorca Thanks again for hard work on the feature. I am convinced we can solve this by better placement and UX, as the feature itself is definitely a great and important addition to Immich. It brings both worlds - web and app - more together and - using e.g. the idea above - without sacrificing / cluttering anything.

[jenda69]

Now this is shame. Just this week I wanted to use this feature two times. Once because I wanted to see path of the image (it often contains location name for untagged pictures in my external library and app doesn't show it), once because I wanted to see the 360 panorama image...

[george1612]

@jenda69 Same here for multiple other use cases. Feel free to describe your missing features and the use cases for this button and general missing features in #21020 .

Furthermore have a look at the linked idea for 360° media: #26692.

Feel free to upvote and share those two issues, so they are hopefully considered for implementation and this PR maybe gets merged with the UI changes I proposed above.

[pedrommvv]

I also would like to see this merged.

[1661410107114145152525]

🥳🥳🥳 So glad to see this being reopened and merged into main! Many thanks to everyone involved for your effort and dedication during implementation, testing and also for reconsidering this great feature. ❤️