feat(mobile): inline asset details#25952
Conversation
c357f0b to
2f68c95
Compare
34db059 to
c230c9c
Compare
|
Hello, I just ran a quick test, and there are two points that need to be changed
|
c230c9c to
9d6f41a
Compare
|
One thing which might be nice - it currently hard stops when scrolling to the bottom, a bouncy / springy scroll would feel a bit better . |
|
Apple Photos fullscreens and hides the time etc. when the bottom sheet is opened. I think that's the nicest behavior |
|
I'm open to trying that. I probably won't be able to take a look until tomorrow evening though. |
mobile/lib/presentation/widgets/asset_viewer/asset_viewer.page.dart
Outdated
Show resolved
Hide resolved
mobile/lib/presentation/widgets/asset_viewer/asset_viewer.page.dart
Outdated
Show resolved
Hide resolved
2082e11 to
8c7896a
Compare
8c7896a to
e034372
Compare
| bool? showingBottomSheet, | ||
| bool? showingDetails, | ||
| bool? showingControls, | ||
| bool? isZoomed, |
There was a problem hiding this comment.
we basically need this to prevent scrolling pages when zoomed in (an existing bug)
mobile/lib/presentation/widgets/asset_viewer/asset_viewer.page.dart
Outdated
Show resolved
Hide resolved
|
I just tested on iOS and noticed a few things
|
|
Thanks for trying this out @alextran1502. I'll look at this tonight as I am keen to get this merged. I don't have an iOS device to test on, would you mind sharing a video? Is the map thing an existing issue? I haven't changed anything there. |
The existing implementation for showing asset details uses a bottom sheet, and is not in sync with the preview or scroll intent. Other apps use inline details, which is much cleaner and feels better to use.


Description
The existing implementation for showing asset details uses a bottom sheet, and is not in sync with the preview or scroll intent. Other apps use inline details, which is much cleaner and feels better to use.
How Has This Been Tested?
Tested in an emulator.
Screenshots (if appropriate)
demo2.mp4
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
I did use Claude Code to bounce ideas off of, but most of the code is written by me, and any code written with the help of Claude has been reviewed.