feat(mobile): Allow users to set profile picture from asset viewer#25517
Merged
alextran1502 merged 28 commits intoimmich-app:mainfrom Feb 22, 2026
Merged
feat(mobile): Allow users to set profile picture from asset viewer#25517alextran1502 merged 28 commits intoimmich-app:mainfrom
alextran1502 merged 28 commits intoimmich-app:mainfrom
Conversation
**Root cause:** The autogenerated Dart OpenAPI client (`UsersApi.createProfileImage()`) had two issues: 1. It set `Content-Type: multipart/form-data` without a boundary, which overrode the correct header that Dart's `MultipartRequest` would set (`multipart/form-data; boundary=...`). 2. It added the file to both `mp.fields` and `mp.files`, creating a duplicate text field. **Result:** Multer on the server failed to parse the multipart body, so `@UploadedFile()` was `undefined` → accessing `file.path` in `UserService.createProfileImage()` threw → **500 Internal Server Error**. **Workaround:** Bypass the autogenerated method in `UserApiRepository.createProfileImage()` and send the multipart request directly using the same `ApiClient` (basePath + auth), ensuring: - No manual `Content-Type` header (let `MultipartRequest` set it with boundary) - File only in `mp.files`, not `mp.fields` - Proper filename fallback
This reverts commit 8436cd4.
This reverts commit fcf37d2.
This reverts commit faeed81.
This reverts commit a14a0b7.
…. Replace inline image-to-Uint8List conversion with the new utility in EditImagePage, DriftEditImagePage, and ProfilePictureCropPage.
This reverts commit 68a6165.
…ss type for better user feedback.
This reverts commit 8e85057.
timonrieger
commented
Jan 25, 2026
Comment on lines
+64
to
+67
| Future<bool> upload(XFile file, {String? fileName}) async { | ||
| state = state.copyWith(status: UploadProfileStatus.loading); | ||
|
|
||
| var profileImagePath = await _userService.createProfileImage(file.name, await file.readAsBytes()); | ||
| var profileImagePath = await _userService.createProfileImage(fileName ?? file.name, await file.readAsBytes()); |
Collaborator
Author
There was a problem hiding this comment.
XFile.fromData() ignores the name parameter for IO-backed files (see flutter/flutter#87812 and flutter/packages#4416), so we must pass fileName explicitly, applied in
compatible with existing implementation
Collaborator
Author
There was a problem hiding this comment.
pulled this into a new util function, as we had this in use in three locations now
Member
shenlong-tanwen
left a comment
shenlong-tanwen
left a comment
There was a problem hiding this comment.
It might also be best if we can remove the image_picker dependency and just let user pick a profile picture from their remote assets. But that can be a separate PR. Can you refactor the widget before I start testing the implementation?
Comment on lines
31
to
33
| final cropController = useCropController(); | ||
| final isLoading = useState<bool>(false); | ||
| final didInitCropController = useRef(false); |
Member
There was a problem hiding this comment.
We are moving away from using hooks. Can you refactor this to not use hooks but a StatefulWidget instead?
Collaborator
Author
There was a problem hiding this comment.
done and tested
alextran1502
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to set a profile picture from any remote asset in the mobile app. Users can select a remote asset and crop it before setting it as their profile picture.
setProfilePictureaction button type with visibility logic (owner, not locked, RemoteAsset)SetProfilePictureActionButtonwidgetProfilePictureCropPagewith 1:1 aspect ratio croppingimageToUint8Listutility function to remove duplicate codeuploadProfileImageProviderto accept optionalfileNameparameterHow Has This Been Tested?
setProfilePicturebutton visibility logic covering:Screen Recording
ScreenRecording_01-26-2026.00-29-44_1.mov
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
An LLM was used to generate unit tests for the
setProfilePictureaction button visibility logic, following the existing test patterns in the codebase.