feat(web): don't scroll to visible assets#20729
Merged
alextran1502 merged 1 commit intomainfrom Aug 6, 2025
Merged
Conversation
uhthomas
force-pushed
the
chore-web-dont-scroll-visible-assets
branch
4 times, most recently
from
b17ebe6 to
ec9579f
Compare
Collaborator
Author
|
We could make this a bit better by adding the asset height into the calculation, as right now it jumps to assets which are half visible at the top. I didn't see a function to get the height rather than just the calculated position, so I think it's fine for now as it would need more code changes. |
The timeline has been quite aggressive with scrolling to assets, even if they were right in the middle of the page. If the asset is visible, then we shouldn't scroll to it. It's really confusing when assets jump around after being viewed.
uhthomas
force-pushed
the
chore-web-dont-scroll-visible-assets
branch
from
ec9579f to
3edd256
Compare
uhthomas
changed the title
Contributor
|
Deploying preview environment to https://pr-20729.preview.internal.immich.cloud/ |
alextran1502
approved these changes
Aug 6, 2025
ollioddi
pushed a commit
to ollioddi/immich
that referenced
this pull request
Aug 11, 2025
The timeline has been quite aggressive with scrolling to assets, even if they were right in the middle of the page. If the asset is visible, then we shouldn't scroll to it. It's really confusing when assets jump around after being viewed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The timeline has been quite aggressive with scrolling to assets, even if they were right in the middle of the page. If the asset is visible, then we shouldn't scroll to it. It's really confusing when assets jump around after being viewed.
How Has This Been Tested?
I tested it locally.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)