Skip to content

feat(web): don't scroll to visible assets #20729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alextran1502 merged 1 commit into from
Aug 6, 2025
Merged

feat(web): don't scroll to visible assets #20729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions web/src/lib/components/photos-page/asset-grid.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,28 @@
return height;
};

const assetIsVisible = (assetTop: number): boolean => {
if (!element) {
return false;
}

const { clientHeight, scrollTop } = element;
return assetTop >= scrollTop && assetTop < scrollTop + clientHeight;
};

const scrollToAssetId = async (assetId: string) => {
const monthGroup = await timelineManager.findMonthGroupForAsset(assetId);
if (!monthGroup) {
return false;
}

const height = getAssetHeight(assetId, monthGroup);

// If the asset is already visible, then don't scroll.
if (assetIsVisible(height)) {
return true;
}

scrollTo(height);
updateSlidingWindow();
return true;
Expand Down