Added ENV vars equivalent to four basic placeholder properties #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rendered obsolete by PR #240 |
kris-sigur
pushed a commit
that referenced
this pull request
May 8, 2015
Issue 217, basically the same as PR #220
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of #217 that adds override option to some basic placeholder properties via environment variables and falls back to their current default values. If this idea is accepted, we can make several configurations changeable via ENV vars such as choosing which collection file to import.
To test the working of this implementation, set some system ENV vars and restart the Tomcat. If Docker container is used then ENV vars can be passed at run time. Similarly if deployed on Heroku then
herokuCLI can be used to set these variables.