Issue217 dymamic config params #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…23.230 and WAYBACK_URL_PORT configurable through environment variables.
kris-sigur
pushed a commit
that referenced
this pull request
May 7, 2015
Issue 217 dymamic config params
This was referenced May 7, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The four parameters "wayback.basedir", "wayback.url.scheme", "wayback.url.host" and "wayback.url.port" defined inside wayback.xml are now configurable at startup using environment variables.
The code is only tested on UNIX, using:
export WAYBACK_BASEDIR
export WAYBACK_URL_SCHEME
export WAYBACK_URL_HOST
export WAYBACK_URL_PORT
either from the command line or inside a startup script, but it should also function under Windows using
"set ENV_VAR_NAME=value"