Skip to content

Conversation

@anjackson
Copy link
Member

This basic pull request shows how we could extend the webapp build that includes an integration test phase. This phase spins up a copy of Jetty, pointing to an appropriately configured instance of Wayback, including an example WARC. The integration-test phase unit tests then make requests to the Wayback instance and are capable of verifying the response.

Issues:

  • Uses BDBCollection, should use CDX instead.
  • Could use the same wayback.xml config rather that a dedicated test one if we adopt Added ENV vars equivalent to four basic placeholder properties #220
  • The tests are not very good, and don't really test anything important yet. Note that the test suite does not necessarily have to be written in Java.

Before working on this any further, I wanted to see if this was considered a good move?

@anjackson
Copy link
Member Author

There was a conflict in main/java/org/archive/wayback/archivalurl/requestparser/ArchivalUrlFormRequestParser.java but I'm not sure I resolved it the right way - I left the 'assume its a *' bit in, but perhaps it's now to be taken out?

@kris-sigur
Copy link
Member

The code has moved on. We'd really like this type of integration test, but we'll need to revisit this once the CDX server change has been made with 3.0.0. The BdbCollection is being phased out making this obsolete.

@kris-sigur kris-sigur closed this May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants