Skip to content

chore(lsp): bump iii-sdk to 0.20.0 - #330

Merged
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-lsp
Jun 25, 2026
Merged

chore(lsp): bump iii-sdk to 0.20.0#330
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-lsp

Conversation

@guibeira

@guibeira guibeira commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Bump iii-sdk to 0.20.0 per https://iii.dev/docs/upgrading/from-0-19-x.md. Build, fmt, clippy, tests green (63 tests). lsp is a stdio language server (no registered surface, interface_smoke:false) so no parity diff applies. No iii-helpers needed.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the engine integration to work with the latest supported SDK version.
    • Improved compatibility in language-server features that inspect functions, workers, triggers, and trigger types.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 25, 2026 1:03pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44445a72-7ff7-44b9-a9d2-fe41af22e0c9

📥 Commits

Reviewing files that changed from the base of the PR and between 3fed674 and 175d62c.

⛔ Files ignored due to path filters (1)
  • lsp/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • lsp/Cargo.toml
  • lsp/src/engine_client.rs
  • lsp/src/engine_introspection.rs

📝 Walkthrough

Walkthrough

The LSP crate updates its iii-sdk dependency to 0.20.0 and switches engine client and introspection helpers to the new IIIClient and unified Error types.

Changes

iii-sdk migration

Layer / File(s) Summary
Dependency bump
lsp/Cargo.toml
iii-sdk is pinned from 0.19.2 to 0.20.0.
EngineClient types
lsp/src/engine_client.rs
Imports IIIClient and runtime types, and stores the client in EngineClient.iii as IIIClient.
Introspection signatures
lsp/src/engine_introspection.rs
Imports IIIClient and Error, and updates list_functions, list_workers, list_triggers, and list_trigger_types to use them.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • iii-hq/workers#239: Changes the same engine_introspection.rs path, including list_triggers and list_trigger_types, so it is directly connected to these signature updates.

Suggested reviewers

  • sergiofilhowz

Poem

🐇 I hopped to the newer SDK gate,
With IIIClient I chatter, light and great.
The engine hums clear,
And errors stay near,
While carrots and code both feel first-rate.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: upgrading iii-sdk for the lsp crate to 0.20.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sdk-0.20-lsp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 27 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@guibeira
guibeira merged commit 79d3606 into main Jun 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants