Skip to content

chore(shell): bump iii-sdk to 0.20.0 - #341

Merged
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-shell
Jun 26, 2026
Merged

chore(shell): bump iii-sdk to 0.20.0#341
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-shell

Conversation

@guibeira

@guibeira guibeira commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Bump iii-sdk to 0.20.0 + migrate observability to iii-helpers (iii-observability removed) per https://iii.dev/docs/upgrading/from-0-19-x.md. Build, fmt, clippy, tests green (552 tests); surface parity (17 functions) verified 1:1. No import aliases.

Summary by CodeRabbit

  • Bug Fixes

    • Improved compatibility with the latest shell SDK and updated error handling across command, filesystem, and sandbox flows.
    • Preserved existing behavior for file operations, execution, configuration reloads, and telemetry while making failures report more consistently.
    • Standardized backend and test behavior so remote and handler errors are surfaced more reliably.
  • Chores

    • Updated internal dependencies and supporting observability imports to newer versions.

@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 25, 2026 11:41pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2c698cec-3aa7-4f11-856b-e63be6d75e45

📥 Commits

Reviewing files that changed from the base of the PR and between e57274e and 1dbed11.

⛔ Files ignored due to path filters (1)
  • shell/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (32)
  • shell/Cargo.toml
  • shell/src/configuration.rs
  • shell/src/exec/error.rs
  • shell/src/exec/sandbox.rs
  • shell/src/exec_dispatch.rs
  • shell/src/fs/error.rs
  • shell/src/fs/host.rs
  • shell/src/fs/mod.rs
  • shell/src/fs/sandbox.rs
  • shell/src/functions/exec.rs
  • shell/src/functions/exec_bg.rs
  • shell/src/functions/fs_chmod.rs
  • shell/src/functions/fs_dispatch.rs
  • shell/src/functions/fs_grep.rs
  • shell/src/functions/fs_ls.rs
  • shell/src/functions/fs_mkdir.rs
  • shell/src/functions/fs_mv.rs
  • shell/src/functions/fs_read.rs
  • shell/src/functions/fs_rm.rs
  • shell/src/functions/fs_sed.rs
  • shell/src/functions/fs_stat.rs
  • shell/src/functions/fs_write.rs
  • shell/src/functions/kill.rs
  • shell/src/functions/status.rs
  • shell/src/main.rs
  • shell/src/scode.rs
  • shell/src/telemetry.rs
  • shell/src/triggers.rs
  • shell/tests/function_handlers.rs
  • shell/tests/host_fs_branches.rs
  • shell/tests/sandbox_dispatch.rs
  • shell/tests/sandbox_exec_dispatch.rs

📝 Walkthrough

Walkthrough

The shell crate is updated to iii-sdk 0.20.0, replacing III/IIIError usage with IIIClient and iii_sdk::errors::Error across startup, configuration, exec, filesystem, telemetry, and tests.

Changes

Shell iii-sdk 0.20 migration

Layer / File(s) Summary
Manifest and startup wiring
shell/Cargo.toml, shell/src/main.rs, shell/src/exec_dispatch.rs, shell/src/triggers.rs
The manifest pins iii-sdk 0.20.0, startup imports switch to iii_helpers observability and iii_sdk::errors::Error, and the dispatch helpers accept IIIClient and the new error type.
Configuration client plumbing
shell/src/configuration.rs
Configuration state, runtime build, config fetch, and trigger registration now use IIIClient and map configuration-change errors through iii_sdk::errors::Error.
Error conversions and S-codes
shell/src/exec/error.rs, shell/src/fs/error.rs, shell/src/scode.rs, shell/src/exec/sandbox.rs
Exec and fs error wrappers, shared S-code recovery, and the exec sandbox test stubs now target iii_sdk::errors::Error and its Remote and Handler variants.
Telemetry classification
shell/src/telemetry.rs
Telemetry classification and call recording now operate on Result values that use iii_sdk::errors::Error, and the tests use the new Remote, Handler, and Timeout variants.
Filesystem backend wiring
shell/src/fs/host.rs, shell/src/functions/fs_dispatch.rs, shell/src/fs/mod.rs, shell/src/fs/sandbox.rs, shell/tests/host_fs_branches.rs
Filesystem host, backend selection, stream-direction, and sandbox plumbing now use IIIClient, split channel and error module paths, and the helpers::ChannelDirection enum.
Filesystem handlers and tests
shell/src/functions/fs_*.rs, shell/tests/function_handlers.rs
Filesystem handler entry points now accept IIIClient, return iii_sdk::errors::Error, and keep the same payload parsing and S210 handling; the related FS tests update their stubs and assertions to the new types.
Exec and job handlers
shell/src/functions/exec.rs, shell/src/functions/exec_bg.rs, shell/src/functions/kill.rs, shell/src/functions/status.rs, shell/src/exec/sandbox.rs, shell/tests/function_handlers.rs, shell/tests/sandbox_dispatch.rs, shell/tests/sandbox_exec_dispatch.rs
Exec, background exec, kill, and status handlers now accept IIIClient and return iii_sdk::errors::Error, and the related integration tests and stubs assert the new error variants and call-site mappings.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • iii-hq/workers#80: Same repo-wide iii_sdk migration pattern, including the III/IIIError to IIIClient/errors::Error shift in shell-side handler wiring.
  • iii-hq/workers#328: Also updates iii-sdk client/error plumbing for another worker component, matching the same type and conversion changes used here.
  • iii-hq/workers#330: Also changes shell-adjacent codepaths to use IIIClient and iii_sdk::errors::Error in handler flows and tests.

Suggested reviewers

  • sergiofilhowz
  • ytallo

Poem

A bunny hopped through shell paths bright,
and swapped old hops for cleaner light.
IIIClient twitched, the carrots cheered,
while S-codes bounced where errors veered. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: upgrading shell to iii-sdk 0.20.0.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sdk-0.20-shell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 27 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@guibeira
guibeira marked this pull request as ready for review June 25, 2026 23:50
@guibeira
guibeira merged commit f8af674 into main Jun 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant