Skip to content

chore(image-resize): bump iii-sdk to 0.20.0 - #351

Merged
guibeira merged 2 commits into
mainfrom
chore/sdk-0.20-image-resize
Jun 26, 2026
Merged

chore(image-resize): bump iii-sdk to 0.20.0#351
guibeira merged 2 commits into
mainfrom
chore/sdk-0.20-image-resize

Conversation

@guibeira

@guibeira guibeira commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Bump iii-sdk 0.16.0-next.2 → 0.20.0 per https://iii.dev/docs/upgrading/from-0-19-x.md. Channel types moved to iii_sdk::channel::/iii_sdk::helpers::. Build, fmt, clippy, tests green (58 tests); surface parity (1 function) 1:1. No import aliases. No on-config-change handler (no typed-schema fix needed).

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of image resize handling with broader, more consistent error reporting.
    • Fixed several failure cases during resize processing, including input parsing, stream handling, decoding, encoding, and output writing.
    • Updated the resize component to work with a newer supported SDK version, helping ensure compatibility and stability.

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 26, 2026 8:26pm
workers-tech-spec Ready Ready Preview, Comment Jun 26, 2026 8:26pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@guibeira, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 43 minutes and 53 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 46f31850-3ed5-4d5c-b7d7-524210ad817f

📥 Commits

Reviewing files that changed from the base of the PR and between a4c624c and 5ad05e9.

📒 Files selected for processing (1)
  • image-resize/src/handler.rs
📝 Walkthrough

Walkthrough

The image-resize crate updates its iii-sdk dependency and replaces IIIError-based handler error handling with iii_sdk::errors::Error across resize processing and handler construction.

Changes

Image resize error API migration

Layer / File(s) Summary
Dependency and signatures
image-resize/Cargo.toml, image-resize/src/handler.rs
iii-sdk is pinned to 0.20.0, handler imports switch to Error and extract_channel_refs, and the public handler return types and test import use the new SDK symbols.
Resize stream errors
image-resize/src/handler.rs
handle_resize now maps stream closure, missing metadata, and invalid metadata JSON cases through Error::Handler.
Write path and builder errors
image-resize/src/handler.rs
process_and_write maps parameter resolution, join, decode/encode, serialization, and value conversion failures through Error::Handler, and build_handler maps missing channel refs the same way.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • iii-hq/workers#328: Updates code to use iii_sdk::errors::Error instead of IIIError, matching the same SDK error migration pattern.
  • iii-hq/workers#330: Switches other worker code to the iii-sdk 0.20.0 API, including the same error/type transition.

Suggested reviewers

  • sergiofilhowz

Poem

A rabbit tapped the console light,
and hopped from IIIError into Error right.
🐇 The resize stream twinkled, neat and clear,
with metadata crumbs and no old fear.
I thump, “New SDK, let’s zoom tonight!”

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: upgrading image-resize's iii-sdk dependency to 0.20.0.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sdk-0.20-image-resize

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 27 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@image-resize/src/handler.rs`:
- Around line 5-7: The import path is using the wrong module name for the
channel APIs; `ChannelReader`, `ChannelWriter`, `StreamChannelRef`, and
`extract_channel_refs` should come from `iii_sdk::channels` (or the crate root
re-export), not `iii_sdk::channel`. Update the imports in `handler.rs` to use
the correct `iii_sdk::channels` path so the code matches the `0.20.0` API and
keeps the related channel types together.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f6a18ac2-a64c-4680-8084-f5d468d232b8

📥 Commits

Reviewing files that changed from the base of the PR and between ec096b7 and a4c624c.

⛔ Files ignored due to path filters (1)
  • image-resize/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • image-resize/Cargo.toml
  • image-resize/src/handler.rs

Comment thread image-resize/src/handler.rs Outdated
Per CodeRabbit: ChannelReader/ChannelWriter/StreamChannelRef/ChannelDirection/
extract_channel_refs all live canonically in iii_sdk::channels (the channel/
helpers paths are just re-exports). Consolidate to channels for consistency
with shell and the SDK's canonical module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant