Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links/client side navigation #433

Merged
merged 14 commits into from
Mar 7, 2024
Merged

fix: links/client side navigation #433

merged 14 commits into from
Mar 7, 2024

Conversation

js0mmer
Copy link
Member

@js0mmer js0mmer commented Feb 15, 2024

Description

Some anchor tags were used to link to other pages. Link tags need to be used instead to use react router properly for client side navigation. Also had to fix some useEffect dependencies and keys in some components because data was persisting between changing courses, professors, etc. now that we're actually navigating on the client and not reloading the page.

Next Steps

I think I took care of everything to make navigation work properly but we should do the above steps to be sure and to avoid any inevitable errors that may occur in the future.

Steps to verify/test this change:

  • Verify changes work as expected on staging instance

Final Checks:

  • Verify successful deployment

(optional)

  • Write tests
  • Write documentation

Issues

Closes #

@js0mmer js0mmer temporarily deployed to staging-433 February 15, 2024 08:03 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-433 February 15, 2024 08:03 — with GitHub Actions Inactive
@js0mmer js0mmer self-assigned this Feb 15, 2024
@js0mmer js0mmer temporarily deployed to staging-433 February 23, 2024 21:44 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-433 February 23, 2024 22:11 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-433 March 5, 2024 07:57 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-433 March 7, 2024 01:38 — with GitHub Actions Inactive
@js0mmer js0mmer temporarily deployed to staging-433 March 7, 2024 01:49 — with GitHub Actions Inactive
since filtering by professor has been added, this option can persist if a user
navigates to another page by clicking a course in prereq tree
@js0mmer js0mmer temporarily deployed to staging-433 March 7, 2024 01:50 — with GitHub Actions Inactive
courseGQLData only updates after search result
returns, id can be mismatched. use courseGQLData.id
@js0mmer js0mmer temporarily deployed to staging-433 March 7, 2024 01:56 — with GitHub Actions Inactive
@js0mmer js0mmer merged commit ca829ac into master Mar 7, 2024
3 checks passed
@js0mmer js0mmer deleted the fix-navigation branch March 7, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants