Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: links/client side navigation #433

Merged
merged 14 commits into from
Mar 7, 2024
Merged

fix: links/client side navigation #433

merged 14 commits into from
Mar 7, 2024

Commits on Feb 15, 2024

  1. fix: links/navigation

    @js0mmer
    js0mmer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    53e5753 View commit details
    Browse the repository at this point in the history

  2. fix: some useEffect hooks related to navigation for course/professor … 

    …pages
    @js0mmer
    js0mmer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    83b374f View commit details
    Browse the repository at this point in the history

  3. fix: add key to prereqtree so focus doesn't persist between page changes

    @js0mmer
    js0mmer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    805521c View commit details
    Browse the repository at this point in the history

  4. fix: navigating to nonexistent course and going back clears error now

    @js0mmer
    js0mmer committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e2cdbe7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-navigation

    @js0mmer
    js0mmer authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0cccbc2 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. Merge branch 'master' into fix-navigation

    @js0mmer
    js0mmer committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e11125a View commit details
    Browse the repository at this point in the history

  2. restore prereq tree keys for now

    @js0mmer
    js0mmer committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    89bb257 View commit details
    Browse the repository at this point in the history

  3. add key to schedule component

    @js0mmer
    js0mmer committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5a50747 View commit details
    Browse the repository at this point in the history

  4. also reset error on professor page id change

    @js0mmer
    js0mmer committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    2f94cb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'master' into fix-navigation

    @js0mmer
    js0mmer committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    10ff391 View commit details
    Browse the repository at this point in the history

  2. don't touch footer 

    addressed in another pr
    @js0mmer
    js0mmer committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    152f1b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Merge branch 'master' into fix-navigation

    @js0mmer
    js0mmer authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1c400a1 View commit details
    Browse the repository at this point in the history

  2. fix: add key to review component 

    since filtering by professor has been added, this option can persist if a user
navigates to another page by clicking a course in prereq tree
    @js0mmer
    js0mmer committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    1ddf340 View commit details
    Browse the repository at this point in the history

  3. fix: id used in keys. 

    courseGQLData only updates after search result
returns, id can be mismatched. use courseGQLData.id
    @js0mmer
    js0mmer committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c27cd7c View commit details
    Browse the repository at this point in the history