Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Instructor from Course Instructor History #390

Open
Awesome-E opened this issue Dec 15, 2023 · 1 comment
Open

Missing Instructor from Course Instructor History #390

Awesome-E opened this issue Dec 15, 2023 · 1 comment
Labels
bug Something isn't working Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the

Comments

@Awesome-E
Copy link
Member

Reproduce:

  1. Search up ICS 46
  2. Click on more information

Expected: sub-reviews load correctly
Actual: Sub-reviews don't load

  • No item in instructor_history matches the professorID, so reading its name throws an error (cannot read name of undefined in instructor_history)

We should either make sure the professor is in the instructor history, handle this case, or (ideally) both.

image image

{course && <Link to={{ pathname: `/professor/${review.professorID}` }}>
{course.instructor_history[review.professorID].name}
</Link>}

@js0mmer js0mmer added Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the bug Something isn't working labels Dec 17, 2023
@js0mmer
Copy link
Member

js0mmer commented Feb 15, 2024

Optional chaining operator was added for course subreviews after the api migration. I messed with this in #433 and added optional chaining to the professor subreviews as well since that seemed to have been missed and was throwing errors. Errors for this issue are now prevented but we still have the issue of there being a missing professor or possibly course name (have not seen the latter yet, but plently of the former exists in our dev db).

ics 46 example:

image

We should ask PPAPI how they handle when courses are no longer offered and professors leave. Some professors who have still left are still searchable on PeterPortal (e.g. Pattis, Carey). Some are not searchable.

e.g. Burtsev who taught 143A (review from staging instance)
image

From there, we can figure out how to approach this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Story Point: 3 backend or full-stack change. maybe adding an endpoint or changing the response of an endpoint + the
Projects
Status: Backlog
Development

No branches or pull requests

2 participants