feat: response message solidity #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]>
* fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]>
fix: added rpsc in foundry.toml
…t-new-message-flow
* feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
* feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development/177-xcall-future-proof-messaging #234 +/- ##
==================================================================================
- Coverage 69.66% 69.33% -0.33%
Complexity 64 64
==================================================================================
Files 40 40
Lines 2166 2195 +29
Branches 24 24
==================================================================================
+ Hits 1509 1522 +13
- Misses 647 663 +16
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Base automatically changed from
182-solidity-implement-new-message-flow
to
development/177-xcall-future-proof-messaging
January 15, 2024 07:10
AntonAndell
requested review from
redlarva,
ibrizsabin,
nightowl121 and
AntonAndell
as code owners
…/response-message-evm
AntonAndell
requested changes
Jan 15, 2024
AntonAndell
requested changes
Jan 16, 2024
AntonAndell
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Approved and new issue for improvement on tests created #234
…/response-message-evm
AntonAndell
merged commit fa211ca
into
development/177-xcall-future-proof-messaging
11 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: