Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make simple dapp to use same logic as dapp multi #195

Conversation

AntonAndell
Copy link
Collaborator

@AntonAndell AntonAndell commented Nov 16, 2023

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #195 (71cc538) into main (2baf7aa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #195   +/-   ##
=========================================
  Coverage     70.87%   70.87%           
  Complexity       55       55           
=========================================
  Files            34       34           
  Lines          2012     2012           
  Branches         34       34           
=========================================
  Hits           1426     1426           
  Misses          570      570           
  Partials         16       16           
Flag Coverage Δ
java 81.50% <ø> (ø)
solidity 81.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AntonAndell AntonAndell added the bug Something isn't working label Nov 20, 2023
Copy link
Contributor

@redlarva redlarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AntonAndell AntonAndell force-pushed the 194-running-the-jvm-simple-dapp-contract-and-running-into-unknownfailure branch from 35ebe02 to 71cc538 Compare November 20, 2023 07:59
@redlarva redlarva merged commit 2c92cf7 into main Nov 20, 2023
14 checks passed
@redlarva redlarva deleted the 194-running-the-jvm-simple-dapp-contract-and-running-into-unknownfailure branch November 20, 2023 08:04
AntonAndell added a commit that referenced this pull request Dec 15, 2023
* feat: xcall upgradeable

* fix: foundry toml fix

* deploy mock script

* fix: remapping

* fix: env name changed

* fix: script reformed

* fix: upgradeable using openzeppelin

* fix: upgradeable using openzeppelin

* fix: deploy scripts fix

* fix: deploy scripts fix

* forge install: openzeppelin-foundry-upgrades

* fix: Make simple dapp to use same logic as dapp multi (#195)

* fix: adapters deployment scripts added

* fix: adapters included in script

---------

Co-authored-by: AntonAndell <[email protected]>
AntonAndell added a commit that referenced this pull request Jan 18, 2024
* feat: xcall upgradeable (#179)

* feat: xcall upgradeable

* fix: foundry toml fix

* deploy mock script

* fix: remapping

* fix: env name changed

* fix: script reformed

* fix: upgradeable using openzeppelin

* fix: upgradeable using openzeppelin

* fix: deploy scripts fix

* fix: deploy scripts fix

* forge install: openzeppelin-foundry-upgrades

* fix: Make simple dapp to use same logic as dapp multi (#195)

* fix: adapters deployment scripts added

* fix: adapters included in script

---------

Co-authored-by: AntonAndell <[email protected]>

* fix: network address validation fixed (#212)

* fix: not authorized issue by making handleMessage public (#202)

* fix: not authorized issue by making handleMessage public

* feat: handleBTPMessage tests added

* fix: add fixes for handle Error

* fix: code order optmization in handle message

Signed-off-by: gcranju <[email protected]>

* fix:revert message added in handleRequest

* fix: versions openzeppelin fix

* fix: foundry upgrades deleted

---------

Signed-off-by: gcranju <[email protected]>

* ci: add job to update CHANGELOG.md (#207)

* fix: added rpsc in foundry.toml

* fix: fix env.example

* fix: new message type added in solidity

* feat: add centralized connections in solidity and java (#196)

* feat: solidity xcall connection added

* feat: icon xcall connection added

* fix: checkfee added

* feat: relayer address in centralized connection

* feat: added build scripts

* feat: solidity tests for centralized connection added

* feat: centralized connection name changed for icon

* fix: review comments addressed for solidity part

* fix: variable admin used for relayer/admin

* fix: review comments addressed for javascore part

* fix: variables in build.gradle in centralized cnnection

* fix: java score constructor

* fix: removed void from constructor

* fix: type of receipts to boolean

* fix: solitity tests resolved

* fix: logic corrected for duplicate message

* fix: fee check added in connection

* fix: centralized connection test added in solidity

* fix: admin check removed from getReceipts

Co-authored-by: redlarva <[email protected]>

* fix: onlyAdmin function

* fix: architecture updated (#214)

* fix: architecture updated

* fix: use connectio sn

* style: formatting code

* added scripts for centralized connections

* feat: centralized-connection javascore tests added

* feat: clam fees tests added

---------

Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>

* fix: unnecessary event log removed

* fix: sendBTPMessage renamed to sendToConnection

* fix: unnecessary event log removed

* feat: add centralized connections in solidity and java (#196)

* feat: solidity xcall connection added

* feat: icon xcall connection added

* fix: checkfee added

* feat: relayer address in centralized connection

* feat: added build scripts

* feat: solidity tests for centralized connection added

* feat: centralized connection name changed for icon

* fix: review comments addressed for solidity part

* fix: variable admin used for relayer/admin

* fix: review comments addressed for javascore part

* fix: variables in build.gradle in centralized cnnection

* fix: java score constructor

* fix: removed void from constructor

* fix: type of receipts to boolean

* fix: solitity tests resolved

* fix: logic corrected for duplicate message

* fix: fee check added in connection

* fix: centralized connection test added in solidity

* fix: admin check removed from getReceipts

Co-authored-by: redlarva <[email protected]>

* fix: onlyAdmin function

* fix: architecture updated (#214)

* fix: architecture updated

* fix: use connectio sn

* style: formatting code

* added scripts for centralized connections

* feat: centralized-connection javascore tests added

* feat: clam fees tests added

---------

Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>

* fix: centralized-connection test fixed

* fix: proxy request structure with data hash added

* fix: getFee method

* fix: message encoding decoding fixed

* fix: logs removed

* feat: persistent messaging added in solidity

* fix: foundry upgradeable version

* fix: review changes on persistent messaging

---------

Signed-off-by: gcranju <[email protected]>
Co-authored-by: AntonAndell <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
Co-authored-by: izyak <[email protected]>
Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>
AntonAndell added a commit that referenced this pull request Jan 18, 2024
* feat: xcall upgradeable (#179)

* feat: xcall upgradeable

* fix: foundry toml fix

* deploy mock script

* fix: remapping

* fix: env name changed

* fix: script reformed

* fix: upgradeable using openzeppelin

* fix: upgradeable using openzeppelin

* fix: deploy scripts fix

* fix: deploy scripts fix

* forge install: openzeppelin-foundry-upgrades

* fix: Make simple dapp to use same logic as dapp multi (#195)

* fix: adapters deployment scripts added

* fix: adapters included in script

---------

Co-authored-by: AntonAndell <[email protected]>

* fix: network address validation fixed (#212)

* fix: not authorized issue by making handleMessage public (#202)

* fix: not authorized issue by making handleMessage public

* feat: handleBTPMessage tests added

* fix: add fixes for handle Error

* fix: code order optmization in handle message

Signed-off-by: gcranju <[email protected]>

* fix:revert message added in handleRequest

* fix: versions openzeppelin fix

* fix: foundry upgrades deleted

---------

Signed-off-by: gcranju <[email protected]>

* ci: add job to update CHANGELOG.md (#207)

* fix: added rpsc in foundry.toml

* fix: fix env.example

* fix: new message type added in solidity

* feat: add centralized connections in solidity and java (#196)

* feat: solidity xcall connection added

* feat: icon xcall connection added

* fix: checkfee added

* feat: relayer address in centralized connection

* feat: added build scripts

* feat: solidity tests for centralized connection added

* feat: centralized connection name changed for icon

* fix: review comments addressed for solidity part

* fix: variable admin used for relayer/admin

* fix: review comments addressed for javascore part

* fix: variables in build.gradle in centralized cnnection

* fix: java score constructor

* fix: removed void from constructor

* fix: type of receipts to boolean

* fix: solitity tests resolved

* fix: logic corrected for duplicate message

* fix: fee check added in connection

* fix: centralized connection test added in solidity

* fix: admin check removed from getReceipts

Co-authored-by: redlarva <[email protected]>

* fix: onlyAdmin function

* fix: architecture updated (#214)

* fix: architecture updated

* fix: use connectio sn

* style: formatting code

* added scripts for centralized connections

* feat: centralized-connection javascore tests added

* feat: clam fees tests added

---------

Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>

* fix: unnecessary event log removed

* fix: sendBTPMessage renamed to sendToConnection

* fix: unnecessary event log removed

* feat: add centralized connections in solidity and java (#196)

* feat: solidity xcall connection added

* feat: icon xcall connection added

* fix: checkfee added

* feat: relayer address in centralized connection

* feat: added build scripts

* feat: solidity tests for centralized connection added

* feat: centralized connection name changed for icon

* fix: review comments addressed for solidity part

* fix: variable admin used for relayer/admin

* fix: review comments addressed for javascore part

* fix: variables in build.gradle in centralized cnnection

* fix: java score constructor

* fix: removed void from constructor

* fix: type of receipts to boolean

* fix: solitity tests resolved

* fix: logic corrected for duplicate message

* fix: fee check added in connection

* fix: centralized connection test added in solidity

* fix: admin check removed from getReceipts

Co-authored-by: redlarva <[email protected]>

* fix: onlyAdmin function

* fix: architecture updated (#214)

* fix: architecture updated

* fix: use connectio sn

* style: formatting code

* added scripts for centralized connections

* feat: centralized-connection javascore tests added

* feat: clam fees tests added

---------

Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>

* fix: centralized-connection test fixed

* fix: proxy request structure with data hash added

* fix: getFee method

* fix: message encoding decoding fixed

* fix: logs removed

* feat: response message solidity

* fix: review changes

* feat: tests added

* fix merge issues

---------

Signed-off-by: gcranju <[email protected]>
Co-authored-by: AntonAndell <[email protected]>
Co-authored-by: DeepakBomjan <[email protected]>
Co-authored-by: izyak <[email protected]>
Co-authored-by: red__larva <[email protected]>
Co-authored-by: redlarva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running the jvm simple-dapp contract and running into "unknownFailure"
2 participants