-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: architecture updated #214
fix: architecture updated #214
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feat/centralizeed_connections #214 +/- ##
===================================================================
+ Coverage 71.26% 71.34% +0.07%
Complexity 55 55
===================================================================
Files 35 35
Lines 2036 2038 +2
Branches 34 34
===================================================================
+ Hits 1451 1454 +3
+ Misses 569 568 -1
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: architecture updated * fix: use connectio sn * style: formatting code
* feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
* feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: persistent messaging added in solidity * fix: foundry upgradeable version * fix: review changes on persistent messaging --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
* feat: xcall upgradeable (#179) * feat: xcall upgradeable * fix: foundry toml fix * deploy mock script * fix: remapping * fix: env name changed * fix: script reformed * fix: upgradeable using openzeppelin * fix: upgradeable using openzeppelin * fix: deploy scripts fix * fix: deploy scripts fix * forge install: openzeppelin-foundry-upgrades * fix: Make simple dapp to use same logic as dapp multi (#195) * fix: adapters deployment scripts added * fix: adapters included in script --------- Co-authored-by: AntonAndell <[email protected]> * fix: network address validation fixed (#212) * fix: not authorized issue by making handleMessage public (#202) * fix: not authorized issue by making handleMessage public * feat: handleBTPMessage tests added * fix: add fixes for handle Error * fix: code order optmization in handle message Signed-off-by: gcranju <[email protected]> * fix:revert message added in handleRequest * fix: versions openzeppelin fix * fix: foundry upgrades deleted --------- Signed-off-by: gcranju <[email protected]> * ci: add job to update CHANGELOG.md (#207) * fix: added rpsc in foundry.toml * fix: fix env.example * fix: new message type added in solidity * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: unnecessary event log removed * fix: sendBTPMessage renamed to sendToConnection * fix: unnecessary event log removed * feat: add centralized connections in solidity and java (#196) * feat: solidity xcall connection added * feat: icon xcall connection added * fix: checkfee added * feat: relayer address in centralized connection * feat: added build scripts * feat: solidity tests for centralized connection added * feat: centralized connection name changed for icon * fix: review comments addressed for solidity part * fix: variable admin used for relayer/admin * fix: review comments addressed for javascore part * fix: variables in build.gradle in centralized cnnection * fix: java score constructor * fix: removed void from constructor * fix: type of receipts to boolean * fix: solitity tests resolved * fix: logic corrected for duplicate message * fix: fee check added in connection * fix: centralized connection test added in solidity * fix: admin check removed from getReceipts Co-authored-by: redlarva <[email protected]> * fix: onlyAdmin function * fix: architecture updated (#214) * fix: architecture updated * fix: use connectio sn * style: formatting code * added scripts for centralized connections * feat: centralized-connection javascore tests added * feat: clam fees tests added --------- Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]> * fix: centralized-connection test fixed * fix: proxy request structure with data hash added * fix: getFee method * fix: message encoding decoding fixed * fix: logs removed * feat: response message solidity * fix: review changes * feat: tests added * fix merge issues --------- Signed-off-by: gcranju <[email protected]> Co-authored-by: AntonAndell <[email protected]> Co-authored-by: DeepakBomjan <[email protected]> Co-authored-by: izyak <[email protected]> Co-authored-by: red__larva <[email protected]> Co-authored-by: redlarva <[email protected]>
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: