feat: implement wormhole adapter #144

redlarva · 2023-10-13T14:18:43Z

Description:

Commit Message

feat: implement wormhole adapter

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

I have performed a self-review of my own code
I have documented my code in accordance with the documentation guidelines
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have run the unit tests
I only have one commit (if not, squash them into one commit).
I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

* remove msg encoding in encodeCSMessageResponse * chore: forge init * forge install: forge-std v1.6.1 * initial foundry setup * forge install: openzeppelin-contracts-upgradeable v4.9.3 * forge install: openzeppelin-contracts v4.9.3 * add contract setup script for Callservice for Xcall * add initial test setup for Xcall

* add setAdmin testCases - setAdmin by Owner - setAdmin by unauthorized caller --------- Co-authored-by: AntonAndell <[email protected]>

* add setProtocolFee and getProtocolFee testCases - setProtocolFee by Owner - setProtocolFee by added admin - setProtocolFee by unauthrorized user --------- Co-authored-by: AntonAndell <[email protected]>

* add setProtocolFeeHandler and getProtocolFeeHandler testCases - setProtocolFeeHandler by Owner/Admin - setProtocolFee by unauthrorized user --------- Co-authored-by: AntonAndell <[email protected]>

* add defaultConnection check on sendCallMessage * add defaultConnection setter for xCall * add revert messages on require()

* update encodeCSMessageRequest with protocol encoded code

* add defaultConnection check on sendCallMessage * add defaultConnection setter for xCall * add revert messages on require() * - add CallMessage eventLog for assertion - Add Connection instances - Add required const variables for netTo for NID and dstAccount for addr * add testCase for HandleResponse - DefaultProtocol with access - DefaultProtocol with unauthorized access * TestCases - handleResponse with singleProtocol - handleResponse with singleProtocol by unauthorized * TestCases - handleResponse with MultiProtocol --------- Co-authored-by: AntonAndell <[email protected]>

* TestCases - executeCall using singleProtocol * Add `CallExecuted` eventlogs for assertions * TestCases - executeCall using defaultProtocol * TestCases - executeCall using multiProtocols

* fix: clearing out unused code * fix: clearing out contract part in library --------- Co-authored-by: AntonAndell <[email protected]>

* update solidity document to deploy tthe contract as well as getting ready with forge commands * update solidity document to deploy tthe contract as well as getting ready with forge commands

* TestCases - Rollback using singleProtocol * TestCases - Rollback using DefaultProtocol - Rollback using DefaultProtocol NotAuthorized * TestCases - Rollback using MultiProtocol - Rollback with SuccessMessage * fix rollbackSuccess testcase to remove rollbackMessage eventlog * remove rollbackMessage eventlogs from executeCall()

* - Fix variables - Fix Imports - TestCases - ExecuteRollback using SingleProtocol - ExecuteRollback with DefaultProtocol - ExecuteRollback using MultiProtocol * fix executeRollack testcases

* fix sendCallMessageSingleProtocol testCase * add `CallMessgeSent` eventLog for test * add testCase for sendMessage using multiProtocol * add testCase for sendMessage using defaultProtocol * Fix expectCall on sendMessage TestCases --------- Co-authored-by: AntonAndell <[email protected]>

* fix: deployment script updated * fix: foundry.toml * fix: nid taken from env * update deployment script to add the setup params for xcall-multi * update deploy script on shellScript file to deploy the contracts easily from CLI * add .env example file to follow to deploy the xcall --------- Co-authored-by: sdpbhandari <[email protected]>

* fix imports error after merge * Fix verifySuccess() Add assert on verifySuccess for rollback tests Add assert on verifySuccess for executeRollback tests

* ci: add solidity coverage workflow * ci: test codcov workflow * ci: debug foundy setup issue * ci: debug foundy setup issue * ci: debug foundy setup issue * ci: debug foundy setup issue * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: export foundryup PATH * ci: fix build on forge * ci: fix build on forge * ci: fix build on forge * ci: fix build on forge * ci: fix build on forge * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build path on workflows * ci: fix build paths on workflows * ci: add workflow for solidity-tests * ci: add env on workflow * ci: update test workflow * ci: update test workflow ignore libraries from coverage folder * ci: install lcov * ci: install lcov --------- Co-authored-by: Deepak Bomjan <[email protected]>

refactor: evm folder structure

codecov · 2023-10-13T14:20:51Z

Codecov Report

Merging #144 (a40b45a) into feature/solidity-adapters (6779754) will increase coverage by 4.01%.
The diff coverage is 77.27%.

Additional details and impacted files

@@                       Coverage Diff                       @@
##             feature/solidity-adapters     #144      +/-   ##
===============================================================
+ Coverage                        68.00%   72.01%   +4.01%     
===============================================================
  Files                               32        4      -28     
  Lines                             1919      218    -1701     
  Branches                            33        0      -33     
===============================================================
- Hits                              1305      157    -1148     
+ Misses                             598       61     -537     
+ Partials                            16        0      -16

Flag	Coverage Δ
java	`?`
rust	`?`
solidity	`72.01% <77.27%> (+9.38%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ks/multi-protocol-dapp/MultiProtocolSampleDapp.sol	`72.72% <100.00%> (+72.72%)`	⬆️
contracts/evm/contracts/xcall/CallService.sol	`81.42% <100.00%> (+0.57%)`	⬆️
...vm/contracts/adapters/wormhole/WormholeAdapter.sol	`72.97% <72.97%> (ø)`

... and 29 files with indirect coverage changes

AntonAndell

Due to me merging and chaning minor things there are now many conflicts. Otherwise this looks amazing, good work!

Also want to discuss with you about adding a configurable response fee where we use reciver value to define that. Would give us the option to add automatic payment for reponses.

contracts/evm/contracts/adapters/wormhole/WormholeAdapter.sol

…ole-adapter # Conflicts: # .github/workflows/solidity-cov.yml # .gitmodules # contracts/evm/contracts/adapters/wormhole/WormholeAdapter.sol # contracts/evm/contracts/mocks/multi-protocol-dapp/MultiProtocolSampleDapp.sol # contracts/evm/contracts/xcall/CallService.sol # contracts/evm/foundry.toml # contracts/evm/library/utils/Types.sol # contracts/evm/test/adapters/wormhole/WormholeAdapter.t.sol # contracts/evm/test/xcall/CallService.t.sol

AntonAndell

Looks good, additional review on structure can be made in solidity adapters branch ones both are merged

* feat: implement wormhole adapter * fix: removed event listener for request submitted * tests: added rollback test for wormhole * tests: added admin test * fix: xcall test * feat: add method to update gas limit

* feat: implement wormhole adapter (#144) * feat: implement wormhole adapter * fix: removed event listener for request submitted * tests: added rollback test for wormhole * tests: added admin test * fix: xcall test * feat: add method to update gas limit * feat: implement layerzero adapter (#149) * feat: added interface for layerzero and install dependencies * feat: implement layerzero adapter * fix: test for layer-zero and wormhole * refactor: clean up * feat: add method to update gas limit for layer zero * fix: use contract as refund address --------- Co-authored-by: AntonAndell <[email protected]> * fix: set sn to 0 if response not required * feature: adapter fee airdrop (#176) * feat: incorporate response fee for layerzero * feat: incorporate response fee for wormhole * refactor: remove duplicate dev docs * feat: implement wormhole adapter (#144) * feat: implement wormhole adapter * fix: removed event listener for request submitted * tests: added rollback test for wormhole * tests: added admin test * fix: xcall test * feat: add method to update gas limit * feat: implement layerzero adapter (#149) * feat: added interface for layerzero and install dependencies * feat: implement layerzero adapter * fix: test for layer-zero and wormhole * refactor: clean up * feat: add method to update gas limit for layer zero * fix: use contract as refund address --------- Co-authored-by: AntonAndell <[email protected]> * fix: set sn to 0 if response not required --------- Co-authored-by: AntonAndell <[email protected]>

AntonAndell and others added 28 commits August 21, 2023 10:23

WIP: inital conversion into multi-protocol

165943c

feat: testcase set admin (#80)

0fecbc5

* add setAdmin testCases - setAdmin by Owner - setAdmin by unauthorized caller --------- Co-authored-by: AntonAndell <[email protected]>

feat: testcase set protocol fee (#81)

c082f15

* add setProtocolFee and getProtocolFee testCases - setProtocolFee by Owner - setProtocolFee by added admin - setProtocolFee by unauthrorized user --------- Co-authored-by: AntonAndell <[email protected]>

feat: testcase set protocol fee handler (#82)

632a3bc

* add setProtocolFeeHandler and getProtocolFeeHandler testCases - setProtocolFeeHandler by Owner/Admin - setProtocolFee by unauthrorized user --------- Co-authored-by: AntonAndell <[email protected]>

fix: add default connection setter (#87)

6227495

* add defaultConnection check on sendCallMessage * add defaultConnection setter for xCall * add revert messages on require()

fix: rlp encode library encoding fix for protocols (#89)

8959749

* update encodeCSMessageRequest with protocol encoded code

add successfulResponses record for responses

1237c0f

update successfulResponses variable after response is success

89b50aa

feat: execute call testcases (#91)

7a96955

* TestCases - executeCall using singleProtocol * Add `CallExecuted` eventlogs for assertions * TestCases - executeCall using defaultProtocol * TestCases - executeCall using multiProtocols

fix: clearing out unused code (#98)

42b2740

* fix: clearing out unused code * fix: clearing out contract part in library --------- Co-authored-by: AntonAndell <[email protected]>

docs: solidity xcall deployment (#99)

e979f07

* update solidity document to deploy tthe contract as well as getting ready with forge commands * update solidity document to deploy tthe contract as well as getting ready with forge commands

feat: execute rollback testcases (#93)

e1a914e

* - Fix variables - Fix Imports - TestCases - ExecuteRollback using SingleProtocol - ExecuteRollback with DefaultProtocol - ExecuteRollback using MultiProtocol * fix executeRollack testcases

fix: add verify success test cases (#101)

94d2410

* fix imports error after merge * Fix verifySuccess() Add assert on verifySuccess for rollback tests Add assert on verifySuccess for executeRollback tests

tests: Fix testExecuteRollbackMultiProtocol test

98994e7

refactor: evm folder structure

4acea42

fix: solidity xcall cod coverage

0e901e3

feat: added evm multiprotocol dapp

e6c5842

fix: removed unnecessary imports

086831b

fix: remove cache file

1351c38

fix: add cache to gitignore

16c6fb2

Merge pull request #143 from icon-project/refactor/evm-folder-structure

f683146

refactor: evm folder structure

feat: implement wormhole adapter

cefa15c

redlarva requested review from sdpisreddevil and AntonAndell October 13, 2023 14:18

redlarva added 3 commits October 13, 2023 20:27

fix: removed event listener for request submitted

75834d5

tests: added rollback test for wormhole

7dc4976

tests: added admin test

64b7dd5

redlarva linked an issue Oct 16, 2023 that may be closed by this pull request

Wormhole Adapter #105

Closed

pragyanshrestha-ibriz linked an issue Oct 20, 2023 that may be closed by this pull request

Core Adapter Development for xcall over Wormhole #106

Closed

Base automatically changed from feature/add-evm-multi-protocol-xcall to main October 23, 2023 13:06

AntonAndell requested review from ibrizsabin and nightowl121 as code owners October 23, 2023 13:06

AntonAndell reviewed Oct 24, 2023

View reviewed changes

contracts/evm/contracts/adapters/wormhole/WormholeAdapter.sol Show resolved Hide resolved

contracts/evm/contracts/adapters/wormhole/WormholeAdapter.sol Show resolved Hide resolved

AntonAndell mentioned this pull request Oct 24, 2023

feat: implement layerzero adapter #149

Merged

7 tasks

redlarva changed the base branch from main to feature/solidity-adapters October 30, 2023 03:39

redlarva added 2 commits October 30, 2023 09:40

fix: xcall test

3dda850

redlarva added the feature label Oct 30, 2023

feat: add method to update gas limit

a40b45a

AntonAndell approved these changes Oct 30, 2023

View reviewed changes

AntonAndell merged commit ad79118 into feature/solidity-adapters Oct 30, 2023
12 of 14 checks passed

AntonAndell deleted the feature/implement-wormhole-adapter branch October 30, 2023 10:27

pragyanshrestha-ibriz removed a link to an issue Nov 9, 2023

Wormhole Adapter #105

Closed

This was linked to issues Nov 9, 2023

Avalanche - Wormhole Module #107

Closed

Arbitrum - Wormhole Module #108

Closed

Base - Wormhole Module #109

Closed

Optimism - Wormhole Module #110

Closed

Internal Security Review - Wormhole Adapter #118

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement wormhole adapter #144

feat: implement wormhole adapter #144

redlarva commented Oct 13, 2023 •

edited

Loading

codecov bot commented Oct 13, 2023 •

edited

Loading

AntonAndell left a comment

AntonAndell left a comment

feat: implement wormhole adapter #144

feat: implement wormhole adapter #144

Conversation

redlarva commented Oct 13, 2023 • edited Loading

Description:

Commit Message

Changelog Entry

Checklist:

codecov bot commented Oct 13, 2023 • edited Loading

Codecov Report

AntonAndell left a comment

Choose a reason for hiding this comment

AntonAndell left a comment

Choose a reason for hiding this comment

redlarva commented Oct 13, 2023 •

edited

Loading

codecov bot commented Oct 13, 2023 •

edited

Loading