Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: evm folder structure #143

Conversation

redlarva
Copy link
Contributor

@redlarva redlarva commented Oct 11, 2023

Description:

Commit Message

refactor: evm folder structure

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #143 (16c6fb2) into feature/add-evm-multi-protocol-xcall (b529488) will decrease coverage by 49.81%.
The diff coverage is 7.69%.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           feature/add-evm-multi-protocol-xcall     #143       +/-   ##
=========================================================================
- Coverage                                 68.48%   18.67%   -49.81%     
=========================================================================
  Files                                         3       11        +8     
  Lines                                       165      605      +440     
=========================================================================
  Hits                                        113      113               
- Misses                                       52      492      +440     
Flag Coverage Δ
solidity 18.67% <7.69%> (-49.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...racts/evm/contracts/mocks/dapp/DAppProxySample.sol 0.00% <ø> (ø)
contracts/evm/library/btp2/utils/Integers.sol 0.00% <ø> (ø)
...ontracts/evm/library/btp2/utils/NetworkAddress.sol 0.00% <ø> (ø)
contracts/evm/library/btp2/utils/ParseAddress.sol 0.00% <ø> (ø)
contracts/evm/library/btp2/utils/RLPDecode.sol 0.00% <ø> (ø)
contracts/evm/library/btp2/utils/RLPEncode.sol 0.00% <ø> (ø)
contracts/evm/library/btp2/utils/Strings.sol 0.00% <ø> (ø)
contracts/evm/library/utils/RLPDecodeStruct.sol 0.00% <ø> (ø)
contracts/evm/library/utils/RLPEncodeStruct.sol 0.00% <ø> (ø)
contracts/evm/contracts/xcall/CallService.sol 80.71% <50.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@redlarva redlarva mentioned this pull request Oct 11, 2023
7 tasks
Copy link
Collaborator

@sdpisreddevil sdpisreddevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdpisreddevil sdpisreddevil merged commit f683146 into feature/add-evm-multi-protocol-xcall Oct 11, 2023
9 of 12 checks passed
@sdpisreddevil sdpisreddevil deleted the refactor/evm-folder-structure branch October 11, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants