feat: solidity adapters #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
============================================
+ Coverage 68.83% 70.87% +2.04%
Complexity 55 55
============================================
Files 32 34 +2
Lines 1925 2012 +87
Branches 34 34
============================================
+ Hits 1325 1426 +101
+ Misses 584 570 -14
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Should we make these upgradable for now? Or keep them constant? @redlarva |
I'm uncertain about it, as there is no sensitive information stored in it. Moreover, if there are any connection issues, we have the option to create a new contract or connection, right? So, considering this, I think it shouldn't be made upgradable. |
redlarva
force-pushed
the
feature/solidity-adapters
branch
from
6beef58
to
e7f0102
Compare
This was
linked to
issues
Nov 8, 2023
Closed
Closed
This was
unlinked from
issues
Nov 9, 2023
Closed
Closed
AntonAndell
approved these changes
Nov 9, 2023
* feat: implement wormhole adapter * fix: removed event listener for request submitted * tests: added rollback test for wormhole * tests: added admin test * fix: xcall test * feat: add method to update gas limit
* feat: added interface for layerzero and install dependencies * feat: implement layerzero adapter * fix: test for layer-zero and wormhole * refactor: clean up * feat: add method to update gas limit for layer zero * fix: use contract as refund address --------- Co-authored-by: AntonAndell <[email protected]>
* feat: incorporate response fee for layerzero * feat: incorporate response fee for wormhole * refactor: remove duplicate dev docs
* feat: implement wormhole adapter * fix: removed event listener for request submitted * tests: added rollback test for wormhole * tests: added admin test * fix: xcall test * feat: add method to update gas limit
* feat: added interface for layerzero and install dependencies * feat: implement layerzero adapter * fix: test for layer-zero and wormhole * refactor: clean up * feat: add method to update gas limit for layer zero * fix: use contract as refund address --------- Co-authored-by: AntonAndell <[email protected]>
redlarva
force-pushed
the
feature/solidity-adapters
branch
from
a2cc1cc
to
743e4a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: