Skip to content

IBX-8180: OpenAPI compatible location swap endpoint #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jul 17, 2024
Merged

IBX-8180: OpenAPI compatible location swap endpoint #107

merged 35 commits into from
Jul 17, 2024

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Jun 7, 2024 •
edited
Loading

🎫 Issue IBX-8180

Related PRs:

#95 - please note that this PR requires the mentioned PR, hence base branch is set to ibx-8176-move-location-endpoint-OpenAPI

Description:

The new endpoint follows the given specification:

POST /api/ibexa/v2/content/locations/1/2/54/
Content-Type: application/vnd.ibexa.api.SwapLocationInput+json
Accept: application/json
{
    "SwapLocationInput": {
        "destination": "/1/2"
    }
}

Documentation:

TBD

@barw4 barw4 added the Feature New feature request label Jun 7, 2024
@barw4 barw4 self-assigned this Jun 7, 2024
@barw4 barw4 marked this pull request as ready for review June 7, 2024 14:58
@barw4 barw4 requested a review from a team June 7, 2024 14:58
ViniTou
ViniTou approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from code style issues

Steveb-p
Steveb-p reviewed Jun 13, 2024
View reviewed changes
@barw4 barw4 force-pushed the ibx-8176-move-location-endpoint-OpenAPI branch from 74ebd11 to 0e870aa Compare June 20, 2024 17:32
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch 2 times, most recently from 6ebe87c to 2b87483 Compare June 20, 2024 17:52
@barw4 barw4 requested review from a team and Steveb-p June 20, 2024 18:11
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 16849bb to 230a491 Compare June 20, 2024 18:16
@barw4 barw4 force-pushed the ibx-8176-move-location-endpoint-OpenAPI branch from e9da7c0 to befa06a Compare June 23, 2024 14:42
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch 2 times, most recently from 9b5d8a2 to 4cc79be Compare June 23, 2024 15:04
This was referenced Jun 24, 2024
Merged
Merged
Merged
@barw4 barw4 force-pushed the ibx-8176-move-location-endpoint-OpenAPI branch from 558f9ca to eb6d0aa Compare June 27, 2024 16:17
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 3268d62 to 55e48bf Compare June 27, 2024 16:25
@barw4 barw4 mentioned this pull request Jun 28, 2024
Merged
@barw4 barw4 force-pushed the ibx-8176-move-location-endpoint-OpenAPI branch from 755dd44 to 2151cc5 Compare June 28, 2024 14:39
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 62e73b9 to 8abbae4 Compare June 28, 2024 14:40
konradoboza
konradoboza reviewed Jul 1, 2024
View reviewed changes
tests/lib/Server/Input/Parser/AbstractDestinationLocationInputTest.php
{
private const int TESTED_LOCATION_ID = 22;

protected MockObject&LocationService $locationService;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay-ish, but nut sure if we already agreed upon such code style rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is the only variation that PHPStan is accepting 😌

@barw4 barw4 requested a review from konradoboza July 1, 2024 18:58
@barw4 barw4 force-pushed the ibx-8176-move-location-endpoint-OpenAPI branch from b328f78 to 6a8ffcd Compare July 2, 2024 22:16
barw4 added 19 commits July 16, 2024 09:44
@barw4
IBX-8176: CS
9385eb8
@barw4
IBX-8176: Implemented routing language expression extension handling …
14c6368 
…`Content-Type` header
@barw4
IBX-8176: Added unit tests
f06ee83
@barw4
IBX-8176: Applied review remarks
114ac97
@barw4
IBX-8176: Refactored solution
2f198fe
@barw4
IBX-8176: Refactoring
2363318
@barw4
IBX-8176: Rename the expression function
2423844
@barw4
IBX-8180: OpenAPI compatible location swap endpoint
8a4f5af
@barw4
IBX-8180: Added integration test
35e56ab
@barw4
IBX-8180: Applied review remarks
f785099
@barw4
IBX-8180: Updated functional test
54739e4
@barw4
IBX-8180: Fixed routing definition
cb2b701
@barw4
IBX-8180: Update route definition and functional test
4178b4b
@barw4
IBX-8180: Update functional test
fb7502a
@barw4
IBX-8180: Update functional tests
76c7a2e
@barw4
IBX-8180: Updated routing
0c19ebe
@barw4
IBX-8180: Applied review remarks
b0fb202
@barw4
IBX-8180: Fixed routing
e9a49d5
@barw4
IBX-8180: Applied review remark
989b2f1
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 0227bcc to 989b2f1 Compare July 16, 2024 07:46
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@micszo micszo removed their assignment Jul 17, 2024
@adamwojs adamwojs merged commit 3f1fbf6 into main Jul 17, 2024
@adamwojs adamwojs deleted the ibx-8180-swap-location-endpoint-OpenAPI branch July 17, 2024 09:11
adamwojs added a commit that referenced this pull request Jul 17, 2024
@adamwojs
Revert "IBX-8180: OpenAPI compatible location swap endpoint (#107)"
0c4b216 
This reverts commit 3f1fbf6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

+1 more reviewer

@webhdx webhdx webhdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

@barw4 barw4

Labels

Feature New feature request QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@barw4 @Steveb-p @webhdx @micszo @ViniTou @konradoboza @adamwojs @alongosz @tischsoic