Skip to content

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Jun 24, 2024

🎫 Issue IBX-8174

Related PRs:

#100

Description:

The new endpoint follows the given specification:

POST /api/ibexa/v2/content/trash/71
Content-Type: application/vnd.ibexa.api.RestoreTrashItemInput+json
Accept: application/json
{
    "RestoreTrashItemInput": {
        "destination": "/1/2"
    }
}
or
{
    "RestoreTrashItemInput": {}
}

Documentation:

TBD

@barw4 barw4 added Feature New feature request Ready for review labels Jun 24, 2024
@barw4 barw4 self-assigned this Jun 24, 2024
@barw4 barw4 requested a review from a team June 24, 2024 16:37
@barw4 barw4 force-pushed the ibx-8174-restore-trash-item-endpoint-OpenAPI branch 2 times, most recently from 0a924f3 to c28cd02 Compare June 28, 2024 14:43
@konradoboza konradoboza requested a review from a team July 1, 2024 07:22
@barw4 barw4 force-pushed the ibx-8176-routing-content-type-header-expression branch 2 times, most recently from cf6a637 to 4da63c8 Compare July 1, 2024 09:05
@barw4 barw4 requested a review from konradoboza July 2, 2024 09:52
@barw4 barw4 force-pushed the ibx-8176-routing-content-type-header-expression branch from 4da63c8 to 8692557 Compare July 2, 2024 22:07
@barw4 barw4 force-pushed the ibx-8174-restore-trash-item-endpoint-OpenAPI branch from b39194d to 57e7b40 Compare July 2, 2024 22:19
@konradoboza konradoboza requested a review from a team July 3, 2024 06:34
Base automatically changed from ibx-8176-routing-content-type-header-expression to main July 11, 2024 09:57
@barw4 barw4 force-pushed the ibx-8174-restore-trash-item-endpoint-OpenAPI branch 2 times, most recently from cfa55a5 to 43dd795 Compare July 12, 2024 14:53
@micszo micszo self-assigned this Jul 15, 2024
@micszo
Copy link
Contributor

micszo commented Jul 17, 2024

To be considered during Documentation phase.

Regarding response codes.
According to https://doc.ibexa.co/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#managing-content-untrash-content-item:
403 if parent location destination does not exist
404 if item is not in Trash.

For the new approach 404 is returned in both cases.

@barw4 barw4 force-pushed the ibx-8174-restore-trash-item-endpoint-OpenAPI branch from 8ca41cd to 6f2272d Compare July 17, 2024 11:36
@sonarqubecloud
Copy link

@micszo micszo removed their assignment Jul 17, 2024
@Steveb-p Steveb-p merged commit 345bcf3 into main Jul 17, 2024
@Steveb-p Steveb-p deleted the ibx-8174-restore-trash-item-endpoint-OpenAPI branch July 17, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature request QA approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants