IBX-8180: Applied review remarks

Author: barw4

src/bundle/Resources/config/routing.yml

@@ -405,9 +405,8 @@ ibexa.rest.languages.view:
 
 ibexa.rest.location.swap:
     path: /content/locations/{locationPath}
-    defaults:
-        _controller: Ibexa\Rest\Server\Controller\Location:swap
-    condition: 'is_content_type_compatible(request, "application/vnd.ibexa.api.SwapLocationInput")'
+    controller: Ibexa\Rest\Server\Controller\Location:swap
+    condition: 'ibexa_get_media_type(request) === "SwapLocationInput"'
     methods: [POST]
     requirements:
         locationPath: "[0-9/]+"

src/lib/Server/Input/Parser/AbstractDestinationLocationParser.php

@@ -9,14 +9,15 @@
 
 use Ibexa\Contracts\Core\Repository\LocationService;
 use Ibexa\Contracts\Core\Repository\Values\Content\Location;
-use Ibexa\Contracts\Rest\Exceptions;
 use Ibexa\Contracts\Rest\Input\ParsingDispatcher;
 use Ibexa\Rest\Input\BaseParser;
+use Ibexa\Rest\Server\Exceptions\ValidationFailedException;
 use Ibexa\Rest\Server\Validation\Builder\Input\Parser\BaseInputParserValidatorBuilder;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 
 abstract class AbstractDestinationLocationParser extends BaseParser
 {
+    protected const string PARSER = '';
     public const string DESTINATION_KEY = 'destination';
 
     public function __construct(
@@ -60,18 +61,23 @@ private function extractLocationIdFromPath(string $path): int
     }
 
     /**
+     * @phpstan-assert array{
+     *      'destination': string,
+     *  } $data
+     *
      * @param array<mixed> $data
      *
-     * @throws \Ibexa\Contracts\Rest\Exceptions\Parser
+     * @throws \Ibexa\Rest\Server\Exceptions\ValidationFailedException
      */
     private function validateInputData(array $data): void
     {
         $builder = $this->getValidatorBuilder();
         $builder->validateInputArray($data);
-        $errors = $builder->build()->getViolations();
-        if ($errors->count() > 0) {
-            throw new Exceptions\Parser(
-                "The 'destination' element is malformed or missing."
+        $violations = $builder->build()->getViolations();
+        if ($violations->count() > 0) {
+            throw new ValidationFailedException(
+                static::PARSER,
+                $violations,
             );
         }
     }

src/lib/Server/Input/Parser/MoveLocation.php

@@ -13,6 +13,8 @@
 
 final class MoveLocation extends AbstractDestinationLocationParser
 {
+    protected const string PARSER = 'MoveLocation';
+
     protected function getValidatorBuilder(): BaseInputParserValidatorBuilder
     {
         return new MoveLocationInputValidatorBuilder($this->validator);

src/lib/Server/Input/Parser/SwapLocationInput.php

@@ -13,6 +13,8 @@
 
 final class SwapLocationInput extends AbstractDestinationLocationParser
 {
+    protected const string PARSER = 'SwapLocationInput';
+
     protected function getValidatorBuilder(): BaseInputParserValidatorBuilder
     {
         return new SwapLocationInputValidatorBuilder($this->validator);

tests/lib/Server/Input/Parser/AbstractDestinationLocationInputTest.php

@@ -9,8 +9,8 @@
 namespace Ibexa\Tests\Rest\Server\Input\Parser;
 
 use Ibexa\Contracts\Core\Repository\LocationService;
-use Ibexa\Contracts\Rest\Exceptions\Parser;
 use Ibexa\Core\Repository\Values\Content\Location;
+use Ibexa\Rest\Server\Exceptions\ValidationFailedException;
 use Ibexa\Rest\Server\Input\Parser\AbstractDestinationLocationParser;
 use PHPUnit\Framework\MockObject\MockObject;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
@@ -52,10 +52,12 @@ protected function parse(): void
         );
     }
 
-    protected function parseExceptionOnMissingDestinationElement(): void
+    protected function parseExceptionOnMissingDestinationElement(string $parser): void
     {
-        $this->expectException(Parser::class);
-        $this->expectExceptionMessage("The 'destination' element is malformed or missing.");
+        $this->expectException(ValidationFailedException::class);
+        $this->expectExceptionMessage(
+            sprintf('Input data validation failed for %s', $parser),
+        );
 
         $inputArray = [
             'new_destination' => '/1/2/3',
@@ -66,16 +68,18 @@ protected function parseExceptionOnMissingDestinationElement(): void
         $sessionInput->parse($inputArray, $this->getParsingDispatcherMock());
     }
 
-    protected function parseExceptionOnInvalidDestinationElement(): void
+    protected function parseExceptionOnInvalidDestinationElement(string $parser): void
     {
         $inputArray = [
             'destination' => 'test_destination',
         ];
 
         $sessionInput = $this->getParser();
 
-        $this->expectException(Parser::class);
-        $this->expectExceptionMessage("The 'destination' element is malformed or missing.");
+        $this->expectException(ValidationFailedException::class);
+        $this->expectExceptionMessage(
+            sprintf('Input data validation failed for %s', $parser),
+        );
 
         $sessionInput->parse($inputArray, $this->getParsingDispatcherMock());
     }

tests/lib/Server/Input/Parser/MoveLocationTest.php

@@ -14,19 +14,21 @@
 
 final class MoveLocationTest extends AbstractDestinationLocationInputTest
 {
+    private const string PARSER = 'MoveLocation';
+
     public function testParse(): void
     {
         $this->parse();
     }
 
     public function testParseExceptionOnMissingDestinationElement(): void
     {
-        $this->parseExceptionOnMissingDestinationElement();
+        $this->parseExceptionOnMissingDestinationElement(self::PARSER);
     }
 
     public function testParseExceptionOnInvalidDestinationElement(): void
     {
-        $this->parseExceptionOnInvalidDestinationElement();
+        $this->parseExceptionOnInvalidDestinationElement(self::PARSER);
     }
 
     protected function internalGetParser(): MoveLocation

tests/lib/Server/Input/Parser/SwapLocationInputTest.php

@@ -14,19 +14,21 @@
 
 final class SwapLocationInputTest extends AbstractDestinationLocationInputTest
 {
+    private const string PARSER = 'SwapLocationInput';
+
     public function testParse(): void
     {
         $this->parse();
     }
 
     public function testParseExceptionOnMissingDestinationElement(): void
     {
-        $this->parseExceptionOnMissingDestinationElement();
+        $this->parseExceptionOnMissingDestinationElement(self::PARSER);
     }
 
     public function testParseExceptionOnInvalidDestinationElement(): void
     {
-        $this->parseExceptionOnInvalidDestinationElement();
+        $this->parseExceptionOnInvalidDestinationElement(self::PARSER);
     }
 
     protected function internalGetParser(): SwapLocationInput