IBX-9727: Add missing type hints to content related VO #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
force-pushed
the
add_missing_type_hints_to_content_vo
branch
2 times, most recently
from
d62b2c5 to
ad60dfe
Compare
adamwojs
commented
Jun 3, 2025
phpstan-baseline.neon
Outdated
| message: '#^Property Ibexa\\Contracts\\Core\\Persistence\\Content\\ContentInfo\:\:\$isHidden \(bool\) on left side of \?\? is not nullable\.$#' | ||
| identifier: nullCoalesce.property | ||
| count: 1 | ||
| path: src/lib/Repository/Mapper/ContentDomainMapper.php |
There was a problem hiding this comment.
This will be removed together with missing type hints for persistence layer
adamwojs
force-pushed
the
add_missing_type_hints_to_content_vo
branch
from
e2a33cf to
e0385ad
Compare
adamwojs
force-pushed
the
add_missing_type_hints_to_content_vo
branch
from
72c5e1d to
66f9196
Compare
ezrobot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
konradoboza
reviewed
Jun 4, 2025
src/contracts/Repository/Values/Content/ContentCreateStruct.php
Outdated
Show resolved
Hide resolved
src/contracts/Repository/Values/Content/ContentCreateStruct.php
Outdated
Show resolved
Hide resolved
ViniTou
reviewed
Jun 4, 2025
konradoboza
approved these changes
Jun 5, 2025
adamwojs
force-pushed
the
add_missing_type_hints_to_content_vo
branch
from
d232b91 to
02ae1b9
Compare
alongosz
force-pushed
the
add_missing_type_hints_to_content_vo
branch
2 times, most recently
from
05e896c to
9e82112
Compare
alongosz
force-pushed
the
add_missing_type_hints_to_content_vo
branch
from
9e82112 to
8180a32
Compare
…tentTest::testCreateContentThrowsInvalidArgumentExceptionContentTypeNotSet test
…tentTest::testCreateContentThrowsInvalidArgumentExceptionMainLanguageCodeNotSet test
…oMainLocationLoaderTest test
…n\FieldRenderingExtensionIntegrationTest test
…st::testFindSingleFailMultiple test
…ontent\DraftList\Item\ContentDraftListItem
…ontent\DraftList\Item\UnauthorizedContentDraftListItem
alongosz
force-pushed
the
add_missing_type_hints_to_content_vo
branch
from
6040965 to
a6c5fca
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Baseline only, can be merged after this one:
Description:
Add missing type hints to content related VO
For QA:
Regression run: ibexa/commerce#1358