Skip to content

IBX-9727: Aligned codebase with core content VO strict types changes #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 7, 2025
Merged

IBX-9727: Aligned codebase with core content VO strict types changes #185

merged 16 commits into from
Jul 7, 2025

Conversation

@alongosz
Copy link
Member

@alongosz alongosz commented Jul 3, 2025 •
edited
Loading

Caution

🎫 Issue IBX-9727

Related PRs:

Description:

TBD, for now running CI against the branch.

@alongosz alongosz force-pushed the ibx-9727-add-missing-type-hints-to-content-vo branch from 43220d6 to 38bd46d Compare July 3, 2025 11:36
@alongosz alongosz mentioned this pull request Jul 3, 2025
Merged
@alongosz alongosz marked this pull request as ready for review July 3, 2025 11:42
@alongosz alongosz force-pushed the ibx-9727-add-missing-type-hints-to-content-vo branch from 851b042 to e2f09b7 Compare July 3, 2025 19:07
alongosz added 14 commits July 3, 2025 22:24
@alongosz
[ContentCreate] Added int cast to ownerId and sectionId strict proper…
69b92a5 
…ties
@alongosz
[ContentCreate] Defined array shape of ContentCreate::parse $data arg
acd5d2b
@alongosz
[ContentCreate] Added missing @throws to ContentCreate::parse method
2609dd7
@alongosz
[UserCreate] Defined array shape of UserCreate::parse $data arg
5965545
@alongosz
[UserCreate] Added int cast to sectionId strict property
7438dbf
@alongosz
Added missing type hints to \Ibexa\Rest\Server\Values\RestContentCrea…
7f55edc 
…teStruct
@alongosz
[Tests] Replaced literal FQCN usage with `RestContentCreateStruct::cl…
d839603 
…ass`
@alongosz
[Tests] Dropped unnecessary assertions due to strict types changes
040e22c
@alongosz
[UserGroupCreate] Defined array shape of UserGroupCreate::parse `$dat…
793efff 
…a` arg
@alongosz
[UserGroupCreate] Added int cast to sectionId strict property
7d6b0ce
@alongosz
[Tests] Defined non-nullable remoteId property for Location stub of…
48ec856 
… LocationTest
@alongosz
[Tests] Fixed non-nullable parentRemoteId property for Location stu…
46b9e19 
…b of RestLocationRootNodeTest
@alongosz
[Tests][PHPUnit] Configured UTC timezone for integration tests
862755f
@alongosz
Fixed incorrect default value assignment to Query properties in Trash…
c3d690d 
…ItemListController
@alongosz alongosz force-pushed the ibx-9727-add-missing-type-hints-to-content-vo branch from e2f09b7 to 77030a8 Compare July 3, 2025 20:25
@alongosz alongosz requested a review from tbialcz July 7, 2025 09:33
konradoboza
konradoboza approved these changes Jul 7, 2025
View reviewed changes
@alongosz alongosz force-pushed the ibx-9727-add-missing-type-hints-to-content-vo branch from 8e3d16c to 491a90e Compare July 7, 2025 13:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

@alongosz alongosz merged commit 1360ad6 into main Jul 7, 2025
12 checks passed
@alongosz alongosz deleted the ibx-9727-add-missing-type-hints-to-content-vo branch July 7, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konradoboza konradoboza konradoboza approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

@ciastektk ciastektk Awaiting requested review from ciastektk

@ViniTou ViniTou Awaiting requested review from ViniTou

@barw4 barw4 Awaiting requested review from barw4

@wiewiurdp wiewiurdp Awaiting requested review from wiewiurdp

@tbialcz tbialcz Awaiting requested review from tbialcz

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alongosz @konradoboza @Steveb-p @tischsoic