IBX-9727: Aligned codebase after core content VO type hints changes #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
commented
Jul 1, 2025
Comment on lines
+38
to
+43
| if (isset($value->name)) { | ||
| $data->setName($value->name); | ||
| } | ||
| if (isset($value->languageCode)) { | ||
| $data->setLanguageCode($value->languageCode); | ||
| } |
There was a problem hiding this comment.
Note
Both properties not accept null.
Comment on lines
+37
to
+44
| return new SectionUpdateData( | ||
| new Section( | ||
| [ | ||
| 'identifier' => $value->identifier ?? '', | ||
| 'name' => $value->name ?? '', | ||
| ] | ||
| ) | ||
| ); |
There was a problem hiding this comment.
Note
While SectionUpdateData accepts nulls, core Section VO doesn't anymore. There's Assert NotBlank constraint there attached on full stack, so the outcome is the same for an empty string - no need to test against nulls.
Comment on lines
+123
to
125
| private function generateLocation(int $parentLocationId = self::DEFAULT_PARENT_LOCATION_ID): API\Location | ||
| { | ||
| return new Core\Location(['id' => 3, 'parentLocationId' => $parentLocationId]); |
There was a problem hiding this comment.
Note
Parent location ID cannot be null anymore
Comment on lines
-185
to
175
|
|
||
| self::assertNull( | ||
| $this->viewParametersListener->setContentEditViewTemplateParameters( | ||
| new PreContentViewEvent($contentView) | ||
| ) | ||
| $this->viewParametersListener->setContentEditViewTemplateParameters( | ||
| new PreContentViewEvent($contentView) | ||
| ); |
Comment on lines
-199
to
+186
| self::assertNull( | ||
| $this->viewParametersListener->setUserUpdateViewTemplateParameters( | ||
| new PreContentViewEvent($view) | ||
| ) | ||
| $this->viewParametersListener->setUserUpdateViewTemplateParameters( | ||
| new PreContentViewEvent($view) |
Comment on lines
+78
to
79
| /** @phpstan-ignore argument.type */ | ||
| $this->mapper->reverseMap(new LanguageCreateData()); |
There was a problem hiding this comment.
Note
The error reported here is the essence of this test, so moved this ignore from the baseline to here.
Comment on lines
+87
to
+90
| yield 'simple' => [['identifier' => 'hash', 'name' => 'Lorem']]; | ||
| yield 'without_name' => [['identifier' => 'hash', 'name' => '']]; | ||
| yield 'without_identifier' => [['identifier' => '', 'name' => 'Lorem']]; | ||
| yield 'with_null' => [['identifier' => '', 'name' => '']]; |
There was a problem hiding this comment.
Note
Main reason for touching this test class - changed null to ''.
| { | ||
| $query = new Query(); | ||
| $query->query = $this->createMock(CriterionInterface::class); | ||
| $query->sortClauses = [$this->createMock(SortClause::class)]; |
There was a problem hiding this comment.
Note
Erroneous assignment - originally was SortClause instead of an array of SortClauses
alongosz
requested review from
Steveb-p,
ViniTou,
adamwojs,
barw4,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
konradoboza
approved these changes
Jul 1, 2025
barw4
approved these changes
Jul 1, 2025
ViniTou
approved these changes
Jul 1, 2025
adamwojs
approved these changes
Jul 1, 2025
alongosz
force-pushed
the
ibx-9727-add-missing-type-hints-to-content-vo
branch
from
a4b768e to
96d2bea
Compare
alongosz
force-pushed
the
ibx-9727-add-missing-type-hints-to-content-vo
branch
from
96d2bea to
f76205b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Needs to be merged together with ibexa/core#569
Related PRs:
Description:
Adjusted code after ibexa/core#569 changes with some improvements in the vicinity of changed code.
See the notes in diff comments for reasoning behind the changes.
For QA:
No QA required.