Skip to content

renderer: fix uv calculations once and for all#11770

Merged
vaxerski merged 6 commits into
hyprwm:mainfrom
vaxerski:smooth-resize
Sep 21, 2025
Merged

renderer: fix uv calculations once and for all#11770
vaxerski merged 6 commits into
hyprwm:mainfrom
vaxerski:smooth-resize

Conversation

@vaxerski
Copy link
Copy Markdown
Member

fixes synchronization of ackd sizes, fixes wrong xdg stuff

Removes xdg_geometry uv handling altogether. It wasn't sync'd properly and we send MAXIMIZED anyways, so geometry is pointless.

Needs some testing if I didnt break shit.

fixes synchronization of ackd sizes, fixes wrong xdg stuff
@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 20, 2025

25.09.20-11.40.36.mp4

danke for your work
works fine on ff and foot, electron and chromium is brokey

@vaxerski
Copy link
Copy Markdown
Member Author

I've fixed those, firefox just has a weird bug when toggling float/tile, I am unsure why that happens.

@vaxerski
Copy link
Copy Markdown
Member Author

fixed, please check everything

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 20, 2025

fixed, please check everything

cool, yeah that bug is fixed

now there's a new one, if i resize discord a bunch then let go the window is empty
image

@vaxerski
Copy link
Copy Markdown
Member Author

anything other than discord that does this?

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 20, 2025

anything other than discord that does this?

all chromium / cef / electron ig

25.09.20-17.30.36.mp4

i noticed in the video that the link shows on hover still on bottom left of chromium. subsurface shenanigans i guess

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 20, 2025

image

i don't think its related but wtf is going on with popups on ff, they are spawned in a completely incorrect position and apparently are under the window border too lol

@gulafaran
Copy link
Copy Markdown
Contributor

currently here just opening vesktop then a terminal next to it makes it somehow half sized, it pops to full size when actively resizing but releasing it it pops back to half size.

2025-09-20-213615_hyprshot

@vaxerski
Copy link
Copy Markdown
Member Author

try nao

@gulafaran
Copy link
Copy Markdown
Contributor

try nao

same thing still

@vaxerski
Copy link
Copy Markdown
Member Author

even more fix but I cant repro your vesktop :/

@vaxerski
Copy link
Copy Markdown
Member Author

@fxzzi is everything good on your end? Can you repro the vesktop isseu?

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

@fxzzi is everything good on your end? Can you repro the vesktop isseu?

25.09.21-02.44.50.mp4

original issue with chromium / electron is back

@Zebra2711
Copy link
Copy Markdown
Contributor

@fxzzi is everything good on your end? Can you repro the vesktop isseu?

25.09.21-02.44.50.mp4
original issue with chromium / electron is back

It only happens with xwayland

@gulafaran
Copy link
Copy Markdown
Contributor

@fxzzi is everything good on your end? Can you repro the vesktop isseu?

25.09.21-02.44.50.mp4
original issue with chromium / electron is back

It only happens with xwayland

ah yeah same here

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

my issue is on wayland native, i assume you were talking about toms issue?

@vaxerski
Copy link
Copy Markdown
Member Author

fixed both issues, please see https://www.youtube.com/watch?v=PumFnlu9EIY for more details

anything left?

@gulafaran
Copy link
Copy Markdown
Contributor

fixed both issues, please see https://www.youtube.com/watch?v=PumFnlu9EIY for more details

anything left?

works for me now, video however plays in some weird language.

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

also looks fine for me 👍

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

25.09.21-16.12.06.mp4

caught this on ff, the bottom of the window when it's resized is like stretched

@Zebra2711
Copy link
Copy Markdown
Contributor

caught this on ff, the bottom of the window when it's resized is like stretched

isn't it a lot better than before?

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

wait yeah i'm cooked it's the same on master

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Sep 21, 2025

20250921_18h27m26s_grim

true hyprmoment

@vaxerski vaxerski merged commit 26cbc67 into hyprwm:main Sep 21, 2025
16 of 17 checks passed
@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Sep 21, 2025

25.09.21-16.12.06.mp4

caught this on ff, the bottom of the window when it's resized is like stretched

#11375 (comment)

@fxzzi
Copy link
Copy Markdown
Contributor

fxzzi commented Sep 21, 2025

#11375 (comment)

ah i c

@vaxerski
Copy link
Copy Markdown
Member Author

zenity brok xd

@Justsnoopy30
Copy link
Copy Markdown

After this PR, when scale is 1, chrome and chromium-based apps have become unusable when shrunk past a certain point, with everything becoming compressed and the mouse pointer completely desyncing in the window from where it visibly is. This is not fixed by the follow-up PR.

@vaxerski
Copy link
Copy Markdown
Member Author

ah, yeah. That's beyond their minimum size. They don't support that... we should probably clip it, though...

littleblack111 pushed a commit to littleblack111/Hyprland that referenced this pull request Sep 23, 2025
fixes synchronization of ackd sizes, fixes wrong xdg stuff
lxe pushed a commit to lxe/Hyprland that referenced this pull request Oct 1, 2025
fixes synchronization of ackd sizes, fixes wrong xdg stuff
Mozzarella32 pushed a commit to Mozzarella32/Hyprland that referenced this pull request Oct 8, 2025
fixes synchronization of ackd sizes, fixes wrong xdg stuff
@alba4k
Copy link
Copy Markdown
Contributor

alba4k commented Mar 17, 2026

this seems to have broken fullscreen and float gestures (#12532) (which are still broken to this day)

crthpl pushed a commit to crthpl/Hyprland that referenced this pull request Jun 3, 2026
fixes synchronization of ackd sizes, fixes wrong xdg stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants