Skip to content

renderer: minor fixups to uv calcs#11375

Merged
vaxerski merged 3 commits into
hyprwm:mainfrom
vaxerski:resize-fixes
Aug 8, 2025
Merged

renderer: minor fixups to uv calcs#11375
vaxerski merged 3 commits into
hyprwm:mainfrom
vaxerski:resize-fixes

Conversation

@vaxerski
Copy link
Copy Markdown
Member

@vaxerski vaxerski commented Aug 7, 2025

Should fix, or improve, #11374

needs testing @constantitus @aphelei

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 7, 2025

I don't see any difference

before

before_patch.mp4

after

after_patch.mp4

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 7, 2025

do you have expand_undersized_textures enabled?

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 7, 2025

do you have expand_undersized_textures enabled?

oop I've disabled it yesterday when testing if it changed something and I forgot reenabling it

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 7, 2025

2025-08-07_20-08-1754590784.mp4

sorry for the mic forgot to disable it

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 7, 2025

nice mic bro

anyways looks smooth to me?

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 7, 2025

it's my laptop

output2.mp4

resizing diagonally is smooth but not resizing vertically it's weird

horizontally is also ok

@Kam1k4dze
Copy link
Copy Markdown
Contributor

Kam1k4dze commented Aug 7, 2025

Main:

main.mp4

PR:

with_patch.mp4

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

fixed, try now

@Kam1k4dze
Copy link
Copy Markdown
Contributor

Fixed. Overall resizing is less jittery, but in some cases it still jitters.

fixed.webm

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

ya cant please some people swear to god

@vaxerski vaxerski merged commit 00da445 into hyprwm:main Aug 8, 2025
13 checks passed
@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 8, 2025

resizing is ok but when tiling/floating a window it's worse. Is it a regression ?

after :

output.mp4

before :

output.mp4

Kam1k4dze pushed a commit to Kam1k4dze/Hyprland that referenced this pull request Aug 8, 2025
@constantitus
Copy link
Copy Markdown

resize.mp4

@vaxerski seems like nothing changed

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

@aphelei its literally the same

@constantitus enable expand undersized textures I'm tired of repeating this

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Aug 8, 2025

@aphelei its literally the same

image

here it's more visible. There are white lines when the window becomes a floating window

2025-08-08_20-08-1754677935.mp4

@constantitus
Copy link
Copy Markdown

@constantitus enable expand undersized textures I'm tired of repeating this

I already told you it was not disabled. I even specifically enabled it and it does the same thing.

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

@aphelei thats normal and it would happen before too, it's just likely quite seemingly random as it depends on the specific rendering of your fm

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

@constantitus idk then your pc bad

@constantitus
Copy link
Copy Markdown

@constantitus idk then your pc bad

It's a ryzen 9 5950x, 64 gigs of ram and an rx 5700 xt. Not the greatest but still above average compared to what most people run Hyprland on.
Also xfce4 wayland, which is in it's testing phase, does resize smoothly.

@vaxerski
Copy link
Copy Markdown
Member Author

vaxerski commented Aug 8, 2025

well idk I can't reproduce the stretching anymore

@gulafaran
Copy link
Copy Markdown
Contributor

@constantitus idk then your pc bad

It's a ryzen 9 5950x, 64 gigs of ram and an rx 5700 xt. Not the greatest but still above average compared to what most people run Hyprland on. Also xfce4 wayland, which is in it's testing phase, does resize smoothly.

that does look a lot like dolphin, if you want you can test #11216

@constantitus
Copy link
Copy Markdown

@constantitus idk then your pc bad

It's a ryzen 9 5950x, 64 gigs of ram and an rx 5700 xt. Not the greatest but still above average compared to what most people run Hyprland on. Also xfce4 wayland, which is in it's testing phase, does resize smoothly.

that does look a lot like dolphin, if you want you can test #11216

Tried, nothing changed. File manager is Thunar btw.
Also, issues are def unrelated. I am noticing this issue even on simple opengl apps.

simple ass opengl app All this app does is redraw everything every frame and swap buffers. It does not submit individual damage regions to wayland.
2025-08-09.01-51-51.mp4

@constantitus
Copy link
Copy Markdown

Now I realize, not only is the jittery resize issue is not fixed, but now I'm also noticing the issue mentioned by @aphelei where the image kind of gets sucked towards the edge when you shrink the window

shrink

I'm 100% sure this issue wasn't there before (in Hyprland 0.49). Guess I should have never opened that discussion.

@vaxerski
Copy link
Copy Markdown
Member Author

that is normal, you can't prevent stretching without doing something to that. If you disable expand undersized textures, if during resize the app is behind, it will be stretched. Otherwise, it's expanded like this. Some compositors will literally leave empty space which looks the worst imo

@aphelei
Copy link
Copy Markdown
Contributor

aphelei commented Sep 21, 2025

@aphelei its literally the same

image

here it's more visible. There are white lines when the window becomes a floating window
2025-08-08_20-08-1754677935.mp4

with #11770 it's perfect

2025-09-21_21-09-1758484712.mp4

Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 27, 2025
Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 27, 2025
Boom-Hacker pushed a commit to Boom-Hacker/Hyprland that referenced this pull request Sep 27, 2025
crthpl pushed a commit to crthpl/Hyprland that referenced this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants