texture: avoid issuing many glTexSubImage2D calls#11216
Closed
gulafaran wants to merge 1 commit into
Closed
Conversation
applications that use QtWidgets like dolphin adds each folder item or individual file to the damage region and gives us a lot of different regions. issuing multiple glTexSubImage2D calls is slow but on the other hand smaller regions can still be faster by simply calling glTexSubImage2D on each of them. the tradeoff is uploading the extent region a few pixels that perhaps wasnt damaged yet again. but should be fine doing so. so if case the rects size and pack the buffer extents and upload it in one call, and if few rects do it as before.
2 tasks
Contributor
Author
|
breaks dbeaver, il close this for now until its actually profiled as a slow thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applications that use QtWidgets like dolphin adds each folder item or individual file to the damage region and gives us a lot of different regions.
issuing multiple glTexSubImage2D calls is slow but on the other hand smaller regions can still be faster by simply calling glTexSubImage2D on each of them.
the tradeoff is uploading the extent region a few pixels that perhaps wasnt damaged yet again. but should be fine doing so.
so if case the rects size and pack the buffer extents and upload it in one call, and if few rects do it as before.