Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #13

Merged
merged 67 commits into from
Aug 26, 2015
Merged

Refactor #13

merged 67 commits into from
Aug 26, 2015

Commits on Aug 10, 2015

  1. Add interface

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    3265bbe View commit details
    Browse the repository at this point in the history

  2. Add console outputs

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    c62606e View commit details
    Browse the repository at this point in the history

  3. Add image storage array

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    d5e43e3 View commit details
    Browse the repository at this point in the history

  4. Add array of views

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    1c14032 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #1 from richardoti/refactor 

    Refactor
    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    cfbf8fb View commit details
    Browse the repository at this point in the history

  6. Fix affine transform bug

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    bf514e0 View commit details
    Browse the repository at this point in the history

  7. Make ImageStack a singleton

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    d00b669 View commit details
    Browse the repository at this point in the history

  8. Add stub for view generation

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    c231179 View commit details
    Browse the repository at this point in the history

  9. Make scheme shared

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    b0a252e View commit details
    Browse the repository at this point in the history

  10. Separate model (ImageStack) and View (StackView(

    @richardtop
    richardtop committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    d26d087 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2015

  1. MVP

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    c2be320 View commit details
    Browse the repository at this point in the history

  2. Add PUSH to stack

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    24bba2e View commit details
    Browse the repository at this point in the history

  3. Drop Wrapper to the floor

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    3af3d1e View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2 from richardoti/refactor 

    Refactor
    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    24af5c8 View commit details
    Browse the repository at this point in the history

  5. Refactor ImageStack

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    094bdf9 View commit details
    Browse the repository at this point in the history

  6. Refactor StackView

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    4f0de9e View commit details
    Browse the repository at this point in the history

  7. Comment-out temporarily unused functions

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    c64a720 View commit details
    Browse the repository at this point in the history

  8. Merge pull request #3 from richardoti/refactor 

    Refactor
    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    7d1b645 View commit details
    Browse the repository at this point in the history

  9. Show images in correct order

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    622c719 View commit details
    Browse the repository at this point in the history

  10. Delegate method to map

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    ab44a32 View commit details
    Browse the repository at this point in the history

  11. Add array of views and gesture recognizer

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    070efcd View commit details
    Browse the repository at this point in the history

  12. Refactor delegate methods

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    e512178 View commit details
    Browse the repository at this point in the history

  13. Refactor StackView

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    ff32539 View commit details
    Browse the repository at this point in the history

  14. Refactor stack view

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    ca040fa View commit details
    Browse the repository at this point in the history

  15. Remove debugging code from ImageStack

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    a8ef893 View commit details
    Browse the repository at this point in the history

  16. Fully remove ImageWrapper

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    75552f7 View commit details
    Browse the repository at this point in the history

  17. Refactor variable names to StackView

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    1afb0d3 View commit details
    Browse the repository at this point in the history

  18. Fully refactor remains of Wrapper

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    62104dd View commit details
    Browse the repository at this point in the history

  19. Remove shared scheme

    @richardtop
    richardtop committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    5ea7743 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2015

  1. Merge branch 'master' of https://github.com/hyperoslo/ImagePicker 

    Conflicts:
	Source/BottomView/BottomContainerView.swift
	Source/BottomView/ImageWrapper.swift
	Source/ImagePickerController.swift
    @richardtop
    richardtop committed Aug 14, 2015
    Configuration menu
    Copy the full SHA
    d9186a6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #12 from richardoti/master 

    Transfer branch
    @richardtop
    richardtop committed Aug 14, 2015
    Configuration menu
    Copy the full SHA
    b2f2990 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2015

  1. Make stack to work like real stack (append to head)

    @richardtop
    richardtop committed Aug 17, 2015
    Configuration menu
    Copy the full SHA
    d1a5cc3 View commit details
    Browse the repository at this point in the history

  2. Fix correct ordering of pictures

    @richardtop
    richardtop committed Aug 17, 2015
    Configuration menu
    Copy the full SHA
    eb8f80c View commit details
    Browse the repository at this point in the history

  3. Add TODO

    @richardtop
    richardtop committed Aug 17, 2015
    Configuration menu
    Copy the full SHA
    35b09b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2015

  1. Revert previous behavior (append to the end)

    @richardtop
    richardtop committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    aafbee9 View commit details
    Browse the repository at this point in the history

  2. Add animations

    @richardtop
    richardtop committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    3f2ad44 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #14 from hyperoslo/improve/imageStack 

    Improve/image stack
    @richardtop
    richardtop committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    4707d74 View commit details
    Browse the repository at this point in the history

  4. No println's are allowed

    @richardtop
    richardtop committed Aug 18, 2015
    Configuration menu
    Copy the full SHA
    6892ca7 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2015

  1. Correct layout to match original

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    9767f45 View commit details
    Browse the repository at this point in the history

  2. Change NSMutableArray to array of images

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    8f6743d View commit details
    Browse the repository at this point in the history

  3. Replace delegate with notifications

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    d0c175a View commit details
    Browse the repository at this point in the history

  4. Bind photo button label to notifications

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    5492b09 View commit details
    Browse the repository at this point in the history

  5. Subscribe at correct place

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    65e7133 View commit details
    Browse the repository at this point in the history

  6. Re-indent

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    a576b4c View commit details
    Browse the repository at this point in the history

  7. Remove extra pushes to stack

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    006457b View commit details
    Browse the repository at this point in the history

  8. ImageStack - make class, send sender with notifications

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    6b6d7c2 View commit details
    Browse the repository at this point in the history

  9. Stackview - remove shared instance

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    c4675a5 View commit details
    Browse the repository at this point in the history

  10. Remove shared instance from Picker shutter button

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    7411f83 View commit details
    Browse the repository at this point in the history

  11. Remove shared instance from datasource

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    b87bf7b View commit details
    Browse the repository at this point in the history

  12. Remove shared instance from controller

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    b800bc5 View commit details
    Browse the repository at this point in the history

  13. Remove shared instance / delegate methods from gallery

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    5356ec7 View commit details
    Browse the repository at this point in the history

  14. Fully remove shared stack

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    a14ecd5 View commit details
    Browse the repository at this point in the history

  15. Merge pull request #16 from hyperoslo/remove-shared-instance 

    Remove shared instance
    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    3a3778b View commit details
    Browse the repository at this point in the history

  16. Remove shared stack from the controller

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    623daf8 View commit details
    Browse the repository at this point in the history

  17. Remove commented code

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    eea9fd9 View commit details
    Browse the repository at this point in the history

  18. Fix gesture recognizers and make interface compatible

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    d3688c2 View commit details
    Browse the repository at this point in the history

  19. Make vars and methods public

    @richardtop
    richardtop committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    50c624a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2015

  1. Change button title at one point only

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    d7f5ca4 View commit details
    Browse the repository at this point in the history

  2. Add stack-reload notification

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    b95a87d View commit details
    Browse the repository at this point in the history

  3. Fix improper view rendering

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    d1f4913 View commit details
    Browse the repository at this point in the history

  4. Reload collectionview automatically on source change

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    ca73037 View commit details
    Browse the repository at this point in the history

  5. Revert "Reload collectionview automatically on source change" 

    This reverts commit ca73037.
    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    8bde548 View commit details
    Browse the repository at this point in the history

  6. Add public method to reset images in stack

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    d403ff7 View commit details
    Browse the repository at this point in the history

  7. Make only one placeholder visible at a time

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    1148868 View commit details
    Browse the repository at this point in the history

  8. Refactor according to the suggestions

    @richardtop
    richardtop committed Aug 25, 2015
    Configuration menu
    Copy the full SHA
    6490e0c View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2015

  1. Refactor according to the suggestions

    @richardtop
    richardtop committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    72955c7 View commit details
    Browse the repository at this point in the history

  2. Refactor according to the suggestions

    @richardtop
    richardtop committed Aug 26, 2015
    Configuration menu
    Copy the full SHA
    4f80265 View commit details
    Browse the repository at this point in the history