Refactor #13
Merged
Refactor #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Source/BottomView/BottomContainerView.swift Source/BottomView/ImageWrapper.swift Source/ImagePickerController.swift
|
|
||
| func adjustButtonTitle(notification: NSNotification) { | ||
| if let sender = notification.object as? ImageStack { | ||
| let title = sender.images.count != 0 ? |
| //TODO: subclass view and use setimage method here to automatically adjust alpha and NIL | ||
| views.map { $0.image = nil } | ||
| views.map { $0.alpha = 0 } | ||
| views[0].alpha = 1 |
There was a problem hiding this comment.
Could you do?
views.first.alpha = 1
|
@hyperoslo/myshop-ios this looks fine to me. what do you guys think? |
|
Having a look now. |
| [topView, cameraController.view, galleryView, bottomContainer].map { self.view.addSubview($0) } | ||
| view.backgroundColor = self.configuration.mainColor | ||
|
|
||
| setupConstraints() | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
You could remove this extra newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've separated view (StackView) from model (ImageStack), so we could easily swap views if needed.
Now ImageStack is the model object which represents selected photos. As it's state is being shown by multiple items (StackView, selected photos number) - I use notifications to change their state.
I've removed some delegate calls as they are not needed now, as the controller owns the stack and passes it to the collection view.
It is possible to reuse separate components. StackView and ImageStack were designed to be reusable - i.e. it is possible to swap view with any other, or add more/less images.
Tested on device.
@RamonGilabert how do you feel about it? I think, now it is finalized