Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation #1

Merged
merged 44 commits into from
Aug 5, 2015
Merged

First implementation #1

merged 44 commits into from
Aug 5, 2015

Conversation

RamonGilabert
Copy link
Contributor

No description provided.

@RamonGilabert RamonGilabert changed the title First implementation, bottom view [WIP] First implementation, bottom view Aug 5, 2015
@RamonGilabert RamonGilabert changed the title [WIP] First implementation, bottom view [WIP] First implementation Aug 5, 2015
@richardtop
Copy link
Contributor

Unable to run, check this issue: #2

@richardtop richardtop changed the title [WIP] First implementation First implementation Aug 5, 2015
// MARK: - Action methods

func doneButtonDidPress(button: UIButton) {
if button.currentTitle == self.configuration.cancelButtonTitle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may guess, you can remove self

button.setImage(self.getImage("flashIcon"), forState: .Normal)
button.setTitle("AUTO", forState: .Normal)
button.titleEdgeInsets = UIEdgeInsetsMake(0, 4, 0, 0)
button.setTitleColor(UIColor(red:0.98, green:0.98, blue:0.45, alpha:1), forState: .Normal)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, this may be extracted to properties, so they may be customized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see that color to be customizable, it's the one by default in Apple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then that's OK

RamonGilabert added a commit that referenced this pull request Aug 5, 2015
@RamonGilabert RamonGilabert merged commit 12148de into master Aug 5, 2015
@RamonGilabert RamonGilabert deleted the feature/first-implementation branch August 5, 2015 15:42
richardtop added a commit that referenced this pull request Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants