Fix TODO from last PR, GetPeerPool returning pool.

[srh]

This change is 

[manishrjain]

Some comments. Please address before submitting.

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

worker/draft.go, line 51 at r1 (raw file):

	addr string
	// An owning reference to a pool for this peer (or nil if addr is sufficiently
	// bogus).

100 char lines. This can fit in last line.

---

worker/draft.go, line 65 at r1 (raw file):

var (
	errNoPeerPoolEntry = fmt.Errorf("no peerPool entry")
	errNoPeerPoolPool  = fmt.Errorf("no peerPool pool, could not connect")

errNoPeerPool (not need to repeat). Or, errNoPeerPoolConn. (all this needs naming refactor, let's get to it asap).

---

worker/draft.go, line 709 at r1 (raw file):

	// Should invalidate/remove pl's to this group only ideally
	posting.EvictGroup(n.gid)
	_, err = populateShard(n.ctx, pool, n.gid)

if _, err := populateShard(..); err != nil

---

worker/draft.go, line 713 at r1 (raw file):

		// TODO: We definitely don't want to just fall flat on our face if we can't
		// retrieve a simple snapshot.
		log.Fatalf("Cannot retrieve snapshot from peer %v, error: %v\n",

If we still have log.Fatalf, you can just use x.Check2f. If you intend to replace it with something, then change the code when you're going to do it (a rule of thumb we follow is to only modify code to improve it. Placeholders are better done via TODOs).

---

Comments from Reviewable

[srh]

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

---

worker/draft.go, line 713 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

If we still have log.Fatalf, you can just use x.Check2f. If you intend to replace it with something, then change the code when you're going to do it (a rule of thumb we follow is to only modify code to improve it. Placeholders are better done via TODOs).

x.Check2f doesn't work, in general, because you can't pass multiple return values as function parameters if there are other parameters.

---

Comments from Reviewable

[srh]

In master as of 1dc6965.