Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From and to argument in shortest path should accept uid variables #1243

Closed
pawanrawal opened this issue Jul 25, 2017 · 3 comments · Fixed by #3710
Closed

From and to argument in shortest path should accept uid variables #1243

pawanrawal opened this issue Jul 25, 2017 · 3 comments · Fixed by #3710
Assignees
@pawanrawal
Labels
area/querylang/algos Related to graph algorithms, such as k-shortest path. area/querylang Issues related to the query language specification and implementation. exp/intermediate Fixing this requires some experience with the project. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.
Milestone
Unplanned (v1.x)

Comments

@pawanrawal
Copy link
Contributor

pawanrawal commented Jul 25, 2017 •
edited by dgraph-bot
Loading

from and to function in shortest path query doesn't accept a uid variable, hence a user must know the know the exact uid while doing a shortest path query.

We should allow using uid variable from another query block. We can assert that length of uid variable should be one.
@pawanrawal pawanrawal added this to the v0.9Maybe milestone Jul 25, 2017
@pawanrawal pawanrawal modified the milestones: v0.9Maybe, v1.x Jan 21, 2018
@birdayz
Copy link

birdayz commented Jan 1, 2019 •
edited
Loading

Is this on the roadmap? From my point of view, as someone who just recently started working with dgraph, it's surprising that it's not possible.

edit: i know that i can just query for the uids in a separate query, but it looks more like a workaround than the way you should do it..

@manishrjain manishrjain added kind/enhancement Something could be better. exp/intermediate Fixing this requires some experience with the project. and removed improvement labels Jan 15, 2019
@martinmr martinmr mentioned this issue Jan 18, 2019
Closed
@martinmr
Copy link
Contributor

The fix for this issue should also work for the k-shortest path algorithm.

This was referenced May 31, 2019
Closed
Closed
@campoy campoy added area/querylang Issues related to the query language specification and implementation. status/accepted We accept to investigate/work on it. labels Jun 21, 2019
@campoy campoy modified the milestones: v1.x, Unplanned Jul 8, 2019
@campoy campoy added area/querylang/algos Related to graph algorithms, such as k-shortest path. and removed area/querylang/algos Related to graph algorithms, such as k-shortest path. labels Jul 11, 2019
@pawanrawal pawanrawal self-assigned this Jul 23, 2019
@pawanrawal pawanrawal mentioned this issue Jul 23, 2019
Merged
pawanrawal added a commit that referenced this issue Jul 24, 2019
@pawanrawal
Support uid variables in from and to arguments for shortest path query
e169f2c 
From and to arguments for a shortest path query could only take hard coded uid values earlier. This change adds support for accepting UID variables defined in other queries as well. This works as long as the UID variables return a single UID. If they return more than one UID, then an error is returned to the user.

Resolves: #1243
jarifibrahim pushed a commit that referenced this issue Mar 16, 2020
Update badger to commit 91c31ebe8c22 (#4935)
cc3c5cd 
Important changes
```
 - Changes to overlap check in compaction.
 - Remove 'this entry should've been caught' log.
 - Changes to write stalling on levels 0 and 1.
 - Compression is disabled by default in Badger.
 - Bloom filter caching in a separate ristretto cache.
 - Compression/Encryption in background.
 - Disable cache by default in badger.
```

The following new changes are being added from badger
`git log ab4352b00a17...91c31ebe8c22`

```
91c31eb Disable cache by default (#1257)
eaf64c0 Add separate cache for bloom filters (#1260)
1bcbefc Add BypassDirLock option (#1243)
c6c1e5e Add support for watching nil prefix in subscribe API (#1246)
b13b927 Compress/Encrypt Blocks in the background (#1227)
bdb2b13 fix changelog for v2.0.2 (#1244)
8dbc982 Add Dkron to README (#1241)
3d95b94 Remove coveralls from Travis Build(#1219)
5b4c0a6 Fix ValueThreshold for in-memory mode (#1235)
617ed7c Initialize vlog before starting compactions in db.Open (#1226)
e908818 Update CHANGELOG for Badger 2.0.2 release. (#1230)
bce069c Fix int overflow for 32bit (#1216)
e029e93 Remove ExampleDB_Subscribe Test (#1214)
8734e3a Add missing package to README for badger.NewEntry (#1223)
78d405a Replace t.Fatal with require.NoError in tests (#1213)
c51748e Fix flaky TestPageBufferReader2 test (#1210)
eee1602 Change else-if statements to idiomatic switch statements. (#1207)
3e25d77 Rework concurrency semantics of valueLog.maxFid (#1184) (#1187)
4676ca9 Add support for caching bloomfilters (#1204)
c3333a5 Disable compression and set ZSTD Compression Level to 1 (#1191)
0acb3f6 Fix L0/L1 stall test (#1201)
7e5a956 Support disabling the cache completely. (#1183) (#1185)
82381ac Update ristretto to version  8f368f2 (#1195)
3747be5 Improve write stalling on level 0 and 1
5870b7b Run all tests on CI (#1189)
01a00cb Add Jaegar to list of projects (#1192)
9d6512b Use fastRand instead of locked-rand in skiplist (#1173)
2698bfc Avoid sync in inmemory mode (#1190)
2a90c66 Remove the 'this entry should've caught' log from value.go (#1170)
0a06173 Fix checkOverlap in compaction (#1166)
0f2e629 Fix windows build (#1177)
03af216 Fix commit sha for WithInMemory in CHANGELOG. (#1172)
23a73cd Update CHANGELOG for v2.0.1 release. (#1181)
465f28a Cast sz to uint32 to fix compilation on 32 bit (#1175)
ea01d38 Rename option builder from WithInmemory to WithInMemory. (#1169)
df99253 Remove ErrGCInMemoryMode in CHANGELOG. (#1171)
8dfdd6d Adding changes for 2.0.1 so far (#1168)
```
@ruicore
Copy link

ruicore commented Aug 16, 2020

can give an example? I try to use variables in shortest path but failed，thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawanrawal pawanrawal

Labels
area/querylang/algos Related to graph algorithms, such as k-shortest path. area/querylang Issues related to the query language specification and implementation. exp/intermediate Fixing this requires some experience with the project. kind/enhancement Something could be better. status/accepted We accept to investigate/work on it.
Milestone
Unplanned (v1.x)
7 participants
@martinmr @manishrjain @campoy @pawanrawal @birdayz @ruicore @dgraph-bot