Skip to content

EIP-7883: adjust modexp gas computation#8766

Merged
macfarla merged 3 commits intohyperledger:mainfrom
lu-pinto:pawel-adjustment-eip-7883
Jun 11, 2025
Merged

EIP-7883: adjust modexp gas computation#8766
macfarla merged 3 commits intohyperledger:mainfrom
lu-pinto:pawel-adjustment-eip-7883

Conversation

@lu-pinto
Copy link
Member

@lu-pinto lu-pinto commented Jun 9, 2025

PR description

Implementation of changes to EIP-7883 suggested by Pawel here: ethereum/EIPs#9855

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@lu-pinto lu-pinto force-pushed the pawel-adjustment-eip-7883 branch from 194eccf to 288b546 Compare June 9, 2025 15:00
@macfarla macfarla added the Osaka Osaka fork related - part of Fusaka label Jun 9, 2025
@Gabriel-Trintinalia Gabriel-Trintinalia moved this to In Progress in Osaka Jun 10, 2025
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title adjust modexp gas computation of eip-7883 eip-7883 - adjust modexp gas computation Jun 10, 2025
@Gabriel-Trintinalia Gabriel-Trintinalia changed the title eip-7883 - adjust modexp gas computation EIP-7883: adjust modexp gas computation Jun 10, 2025
Signed-off-by: Luis Pinto <luis.pinto@consensys.net>

spotless

Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
@lu-pinto lu-pinto force-pushed the pawel-adjustment-eip-7883 branch from 288b546 to 90d762a Compare June 10, 2025 10:35
@macfarla macfarla mentioned this pull request Jun 11, 2025
10 tasks
@macfarla macfarla enabled auto-merge (squash) June 11, 2025 09:47
@macfarla macfarla merged commit 803a8f9 into hyperledger:main Jun 11, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Osaka Jun 11, 2025
fab-10 pushed a commit to fab-10/besu that referenced this pull request Jun 11, 2025
* adjust modexp gas computation of eip-7883

Signed-off-by: Luis Pinto <luis.pinto@consensys.net>

* return min gas cost if inputs are zero

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Luis Pinto <luis.pinto@consensys.net>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Osaka Osaka fork related - part of Fusaka performance

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants