Skip to content

[fusaka-devnet-2] EIP-7883#8797

Merged
Gabriel-Trintinalia merged 2 commits intohyperledger:fusaka-devnet-2from
macfarla:7883-return-500-if-max-zero
Jun 11, 2025
Merged

[fusaka-devnet-2] EIP-7883#8797
Gabriel-Trintinalia merged 2 commits intohyperledger:fusaka-devnet-2from
macfarla:7883-return-500-if-max-zero

Conversation

@macfarla
Copy link
Contributor

avoid division by zero; return minimum gas cost of max input length is zero

Signed-off-by: Sally MacFarlane macfarla.github@gmail.com

Fixed Issue(s)

fixes 2 referenceTests

TODO

ExecutionSpecBlockchainTest_65 > execution(String, BlockchainReferenceTestCaseSpec, boolean) > Name: tests/byzantium/eip198_modexp_precompile/test_modexp.py::test_modexp[fork_Osaka-blockchain_test_from_state_test-ModExpInput_base_0x-exponent_0x-modulus_0x-ModExpOutput_returned_data_0x][Osaka] FAILED
    org.opentest4j.AssertionFailedError at ExecutionSpecBlockchainTest_65.java:37

ExecutionSpecStateTest_44 > execution(String, GeneralStateTestCaseEipSpec, boolean) > Name: tests/byzantium/eip198_modexp_precompile/test_modexp.py::test_modexp[fork_Osaka-state_test-ModExpInput_base_0x-exponent_0x-modulus_0x-ModExpOutput_returned_data_0x]-Osaka FAILED
    java.lang.AssertionError at ExecutionSpecStateTest_44.java:37

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

macfarla added 2 commits June 11, 2025 11:18
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@Gabriel-Trintinalia Gabriel-Trintinalia merged commit 19ca610 into hyperledger:fusaka-devnet-2 Jun 11, 2025
3 checks passed
@macfarla macfarla deleted the 7883-return-500-if-max-zero branch June 12, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants