Skip to content

EIP-7883: adjust modexp gas computation #8766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 3 commits into from
Jun 11, 2025
Merged

EIP-7883: adjust modexp gas computation #8766

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90d762a
adjust modexp gas computation of eip-7883
lu-pinto Jun 9, 2025
b98ccf7
return min gas cost if inputs are zero
macfarla Jun 11, 2025
ecdb254
Merge branch 'main' into pawel-adjustment-eip-7883
macfarla Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions evm/src/main/java/org/hyperledger/besu/evm/gascalculator/OsakaGasCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,19 @@ public long modExpGasCost(final Bytes input) {
clampedAdd(BigIntegerModularExponentiationPrecompiledContract.BASE_OFFSET, baseLength);

final long maxLength = Math.max(modulusLength, baseLength);
long multiplicationComplexity = (maxLength + 7L) / 8L;
multiplicationComplexity =
Words.clampedMultiply(multiplicationComplexity, multiplicationComplexity);
if (maxLength <= 0) {
return 500L;
}
long multiplicationComplexity = 16;
long words = (maxLength + 7L) / 8L;
words = Words.clampedMultiply(words, words);
if (maxLength > 32) {
multiplicationComplexity *= 2;
multiplicationComplexity = words * 2;
}

if (multiplicationComplexity == 0) {
return 500L;
} else if (multiplicationComplexity > 0) {
long maxExponentLength = Long.MAX_VALUE / multiplicationComplexity * 3 / 8;
if (exponentLength > maxExponentLength) {
return Long.MAX_VALUE;
}
long maxExponentLength = Long.MAX_VALUE / words * 3 / 8;
if (exponentLength > maxExponentLength) {
return Long.MAX_VALUE;
}

final long firstExponentBytesCap =
Expand Down
Loading